Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include opacity to colors to allow images in cover blocks not to be tinted #45

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

fblupi
Copy link
Member

@fblupi fblupi commented Sep 13, 2023

Fixes #34

If you define 0 opacity, the image won't be tinted.

Example of configuration:
Screenshot 2023-09-13 at 17-06-10 Admin - Nolan Inc

Result:
Screenshot 2023-09-13 at 17-06-36 Nolan Inc

@fblupi fblupi requested a review from davidbeig September 13, 2023 15:07
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.57% 🎉

Comparison is base (110292c) 86.54% compared to head (80ec2f4) 87.12%.

❗ Current head 80ec2f4 differs from pull request most recent head decbfa3. Consider uploading reports for the commit decbfa3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   86.54%   87.12%   +0.57%     
==========================================
  Files          32       33       +1     
  Lines         513      536      +23     
==========================================
+ Hits          444      467      +23     
  Misses         69       69              
Files Changed Coverage Δ
...im/alternative_landing/content_blocks/base_cell.rb 97.50% <100.00%> (+0.83%) ⬆️
lib/decidim/alternative_landing.rb 100.00% <100.00%> (ø)
...ve_landing/content_blocks/content_blocks_shared.rb 90.12% <100.00%> (+0.51%) ⬆️
...b/decidim/alternative_landing/default_opacities.rb 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@davidbeig davidbeig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like your solution!

Good work!

I have re-run the failing test, since it had nothing to do with this PR, and now we can merge it.

@davidbeig davidbeig merged commit 836b8ea into main Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tinted images in cover block
2 participants