-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(component_related_blocks): move shared logic to base cell #32
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
- Coverage 86.78% 86.54% -0.24%
==========================================
Files 32 32
Lines 507 513 +6
==========================================
+ Hits 440 444 +4
- Misses 67 69 +2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd only change some memoization patterns
app/cells/decidim/alternative_landing/content_blocks/base_cell.rb
Outdated
Show resolved
Hide resolved
app/cells/decidim/alternative_landing/content_blocks/base_cell.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Ivan Vergés <[email protected]>
Co-authored-by: Ivan Vergés <[email protected]>
…_landing into fix/consistency
Closes #20
Closes #29