Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component_related_blocks): move shared logic to base cell #32

Merged
merged 14 commits into from
Jun 29, 2023

Conversation

verarojman
Copy link
Contributor

@verarojman verarojman commented Feb 21, 2022

  • Improve consistency for blocks related to components
  • Add spec and lint base cell
  • Add component scope to upcoming meetings cell
  • Use set manifest_name in component-related cells

Closes #20

Closes #29

@verarojman verarojman mentioned this pull request Feb 21, 2022
@verarojman verarojman changed the title fix/consistency fix(component_related_blocks): move shared logic to base cell Feb 21, 2022
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.24 ⚠️

Comparison is base (0f80323) 86.78% compared to head (97409da) 86.54%.

❗ Current head 97409da differs from pull request most recent head 2299977. Consider uploading reports for the commit 2299977 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   86.78%   86.54%   -0.24%     
==========================================
  Files          32       32              
  Lines         507      513       +6     
==========================================
+ Hits          440      444       +4     
- Misses         67       69       +2     
Impacted Files Coverage Δ
...ntent_blocks/alternative_upcoming_meetings_cell.rb 93.54% <50.00%> (-3.23%) ⬇️
...e_landing/content_blocks/latest_blog_posts_cell.rb 93.33% <50.00%> (-3.34%) ⬇️
...im/alternative_landing/content_blocks/base_cell.rb 96.66% <85.71%> (+0.51%) ⬆️
...lternative_upcoming_meetings_settings_form_cell.rb 100.00% <100.00%> (ø)
...ent_blocks/latest_blog_posts_settings_form_cell.rb 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@microstudi microstudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd only change some memoization patterns

@apuertadelaguila apuertadelaguila requested a review from fblupi June 29, 2023 10:56
@fblupi fblupi merged commit 110292c into main Jun 29, 2023
@fblupi fblupi deleted the fix/consistency branch June 29, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blog : "Mostra entrades de qualsevol blog" mostra entrades errònies Add admin specs
4 participants