Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not show unpublished components. delegate title in surveys to the questionnaire #25

Merged
merged 3 commits into from
Dec 10, 2021

Conversation

microstudi
Copy link
Contributor

@microstudi microstudi commented Dec 10, 2021

  • Fixes presenter for surveys (title is not present in the locator)
  • Finds url in surveys via main_proxy as this component is not registered as a resource in Decidim (probably a Decidim bug)
  • only shows published components/participatory spaces
  • Fixes cache for latests posts
  • Optimizes workflows

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #25 (1162c21) into main (2b37170) will increase coverage by 0.76%.
The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   68.03%   68.79%   +0.76%     
==========================================
  Files          31       32       +1     
  Lines         513      532      +19     
==========================================
+ Hits          349      366      +17     
- Misses        164      166       +2     
Impacted Files Coverage Δ
...im/alternative_landing/calendar_event_presenter.rb 66.66% <0.00%> (-2.57%) ⬇️
...lternative_landing/content_blocks/calendar_cell.rb 100.00% <100.00%> (ø)
...e_landing/content_blocks/latest_blog_posts_cell.rb 96.66% <100.00%> (+0.11%) ⬆️
...ternative_landing/needs_content_blocks_snippets.rb 100.00% <100.00%> (ø)
lib/decidim/alternative_landing/engine.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b37170...1162c21. Read the comment docs.

@microstudi microstudi merged commit ca70f71 into main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant