Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PLEP 1 on purpose and guidelines of PLEPs #11

Merged
merged 30 commits into from
Sep 25, 2018

Conversation

namurphy
Copy link
Member

@namurphy namurphy commented Nov 14, 2017

The purpose of this pull request is to establish the procedure and guidelines for creating and revising PlasmaPy Enhancement Proposals (PLEPs).

Parts of this document are adapted from:

Copy link
Contributor

@SolarDrew SolarDrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, @namurphy! There are just a few things I think could do with some extra clarification but otherwise it looks good.

PLEP-0001.md Outdated
include changes to PlasmaPy decision-making processes or management
structure, guidelines, or procedures. A process PLEP will start out
as a proposal and eventually evolve into a document on the
governance of PlasmaPy.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any kind of formal template for such a document? Or would the PLEP remain as is and be marked as a PLEP about governance?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a PLEP template but that's more for standard PLEPs. Do you think we should have separate standard PLEP and process PLEP templates?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily - I'm just not clear on how a PLEP is different once it becomes a 'document on the governance of PlasmaPy'. I guess what I really mean to ask is is it the same document or once it's accepted are we then going to reconstitute it into a more formal document somewhere else?

PLEP-0001.md Outdated

### Creating a PLEP

Before writing a PLEP, it is generally advisable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume there was going to be more here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, my usual way of writing is to start sentences and then forget to finish them. 😖 I was probably going to say it's advisable to bring this up in discussions on Matrix, etc., I think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable :) Bring it up on Matrix, check it's not a duplicate, get informal feedback, all that good stuff.

PLEP-0001.md Outdated

All new PLEPs should begin with a copy of the PLEP template contained
within the PlasmaPy/PlasmaPy-PLEPs repository. This copy should be
renamed to `PLEP-nnnn.md` where `nnnn` is the lowest available PLEP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth explicitly stating what we mean by 'available'? Or will there be a list of available PLEP numbers in the repo README?

PLEP-0001.md Outdated
When major changes to a PLEP are desired, then it is most appropriate
to propose a new PLEP to supercede the old PLEP. The pull request to
supersede a PLEP should change the "status" category in the header of
the old PLEP to "superseded by PLEP nn" where nn is the number of the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be nnnn to match above?

PLEP-0001.md Outdated

Minor changes to a PLEP that do not affect its meaning or intent
(e.g., formatting changes, fixes to typos, updates to links, minor
rewording to improve clarity, and reversing cosmic ray bit flips) do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good ol' C-x M-c M-butterfly....

PLEP-0001.md Outdated
### Submitting a PLEP

All new PLEPs and amendments to PLEPs should be submitted as pull
requests into the PlasmaPy-PLEP repository. The pull request may be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may -> should? Depending on how strongly we want to encourage the transparency.

PLEP-0001.md Outdated
accepted standard, then the sponsor, the editor, or another member of
the Coordinating Committee should email the PlasmaPy list to introduce
the PLEP and request community feedback. The discussion should take
place through normal communication channels. Important points and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate these may change, but is it worth saying here what the 'normal communication channels' are? Or perhaps linking to some kind of 'normal contact channels' page on the website, which we would keep up to date.

PLEP-0001.md Outdated

### PLEP status

The status of a standard or process PLEP may be any of the following:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can an informational PLEP have status or is it omitted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering about this. The status for informational enhancement proposals for other projects is usually "Discussion" but this doesn't seem quite the best way to go about it. Maybe omitting the status of informational PLEPs would be best.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe. But then explicit is better than implicit, right? Perhaps just 'information' would do?

@StanczakDominik
Copy link
Member

StanczakDominik commented Jun 6, 2018

To keep things localised, from yesterday's telecon:

@namurphy
Copy link
Member Author

The Astropy-APEs repository does not yet have a license, so I created #19 instead as a placeholder.

@StanczakDominik @SolarDrew @tulasinandan - Shall we go ahead and finally officially approve this? I vote in support!

Before this, I had made a change that voting could be done by
approving the PR on GitHub.  However, the original author of a PR
cannot approve their own PR, and it would probably work better to have
the votes done in other ways.
@StanczakDominik
Copy link
Member

Let the voting commence!

👍

@namurphy
Copy link
Member Author

👍

@namurphy
Copy link
Member Author

@SolarDrew @StanczakDominik @tulasinandan - A friendly reminder to vote on PLEPs 1, 2, 4, 5, & 7 when you have a chance!

@tulasinandan
Copy link

TNP approves these changes!

@SolarDrew
Copy link
Contributor

LGTM 👍

I think for his hard work in getting these set up and written, @namurphy deserves the honour of merging the first PLEP :)

@namurphy namurphy merged commit 058fca2 into PlasmaPy:master Sep 25, 2018
@namurphy
Copy link
Member Author

Thanks everyone! We have a PLEP!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants