[will take a while] All Rust #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blefaudeux
force-pushed
the
ben/rust
branch
5 times, most recently
from
1db049f to
129bbff
Compare
blefaudeux
force-pushed
the
ben/rust
branch
11 times, most recently
from
5d6963e to
2d3d26c
Compare
[x] proof of concept, pure rust and only pulling images for now [x] using kanal for message passing [x] async page pull [x] small cli with arguments [x] reuse the same client over time, and the same connection pool across the threads [x] image crop and resize [x] pull all the payloads [~] nice threadpool handling, workstealing and all ideally [x] image encoding [*] handle all the requests options [ ] bulletproof all paths [ ] unit tests [x] CI [ ] CD [ ] python wrap
|
removing the PR for now, may be something for Roman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #76 for motivations. Simpler stack and more robust, go+vips combination is proving to be not reliable enough
[x] proof of concept, pure rust and only pulling images for now
[x] using kanal for message passing
[x] async page pull
[x] small cli with arguments
[x] reuse the same client over time, and the same connection pool across the threads
[x] image crop and resize
[x] pull all the payloads
[x] image encoding
[] nicer threadpool. Ideally IO should could be asyncs
[ ] bulletproof all paths
[ ] unit tests
[] CI
[ ] CD