Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Adobe Photoshop #1122

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Conversation

ImperatorS79
Copy link
Contributor

@ImperatorS79 ImperatorS79 commented Sep 10, 2019

Description

Following of #908 . Needs #1121 and #1074.

What works

Begin of installation

What was not tested

End of installtion, the app itself

Test

  • Operating system (and linux kernel version): gitpod
  • Hardware (GPU/CPU): gitpod

Ready for review

  • Script tested as a regular phoenicis user and working (if you have a problem -> create as draft and ask for help).
  • json-align and eslint run according to the documentation.
  • Codacy and travis checked.

Merge Phoenicis/Scripts:master into ImperatorS79/Scripts:master
updated Hearthstone (download application directly) (PhoenicisOrg#383)
@ImperatorS79
Copy link
Contributor Author

@madoar Despite latest change to Zip extraction, I cannot extract the 1.7 GB archive in my vm using phoenicis (2GB ram):

[INFO ] org.phoenicis.tools.archive.Tar (l.56) - Uncompressing /home/vmachine/.Phoenicis/containers/wineprefix/Adobe Photoshop/drive_c/archive.zip to dir /home/vmachine/.Phoenicis/containers/wineprefix/Adobe Photoshop/drive_c/Adobe Photoshop.
[ERROR] org.phoenicis.multithreading.ControlledThreadPoolExecutorService (l.64) - Java heap space
        at java.base/java.nio.file.Files.read(Files.java:3227)
        at java.base/java.nio.file.Files.readAllBytes(Files.java:3287)
        at org.phoenicis.tools.files.FileAnalyser.getMatch(FileAnalyser.java:66)
        at org.phoenicis.tools.files.FileAnalyser.getMimetype(FileAnalyser.java:83)
        at org.phoenicis.tools.archive.Extractor.uncompress(Extractor.java:59)
        at org.phoenicis.tools.archive.Extractor.uncompress(Extractor.java:45)
        at java.base/java.lang.invoke.LambdaForm$DMH/0x0000000100942840.invokeVirtual(LambdaForm$DMH)
        at java.base/java.lang.invoke.LambdaForm$MH/0x0000000100968440.invoke(LambdaForm$MH)
        at java.base/java.lang.invoke.Invokers$Holder.invokeExact_MT(Invokers$Holder)
Caused by host exception: java.lang.OutOfMemoryError: Java heap space

But ArK (KDE archive extractor) do it without any problem.

@plata
Copy link
Collaborator

plata commented Sep 16, 2019

How does the archive look like? Does it contain a large file?

@ImperatorS79
Copy link
Contributor Author

It contains a 1GB sub zip file.

@plata
Copy link
Collaborator

plata commented Sep 17, 2019

Can you validate if you get the same issue if the archive contains only small files?

@ImperatorS79
Copy link
Contributor Author

I need to find a 2 GB zip file with only small files... ^^

@plata
Copy link
Collaborator

plata commented Sep 19, 2019

You could generate one by creating a directory, putting many small files in it and then zip it.

@madoar madoar requested a review from plata October 5, 2019 09:12
@plata
Copy link
Collaborator

plata commented Oct 5, 2019

We cannot merge this if we cannot validate that it's actually working.

@madoar madoar added the requires testing This Pull Request requires by a user that actually owns the software label Nov 25, 2019
@plata
Copy link
Collaborator

plata commented Dec 28, 2019

@ImperatorS79 what's the status here?

@ImperatorS79
Copy link
Contributor Author

ImperatorS79 commented Dec 28, 2019

Did not have the time to test it. I am really busy this year. But I will try to find some time in the current months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires testing This Pull Request requires by a user that actually owns the software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants