Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature.h: use the correct format for U32 for cop_feature_bits #22920

Open
wants to merge 1 commit into
base: blead
Choose a base branch
from

Conversation

tonycoz
Copy link
Contributor

@tonycoz tonycoz commented Jan 16, 2025

Fixes from 32-bit builds:

In file included from dump.c:31:0:
dump.c: In function 'S_do_op_dump_bar':
feature.h:751:29: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'U32 {aka long unsigned int}' [-Wformat=]
         PerlIO_printf(file, "0x%08x", cop->cop_features.bits[0]); \
                             ^
feature.h:751:29: note: in definition of macro 'DUMP_FEATURE_BITS'
         PerlIO_printf(file, "0x%08x", cop->cop_features.bits[0]); \
                             ^~~~~~~~

  • This set of changes does not require a perldelta entry.

@richardleach
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants