Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent double definitions of vararg functions #22917

Open
wants to merge 1 commit into
base: blead
Choose a base branch
from
Open

Prevent double definitions of vararg functions #22917

wants to merge 1 commit into from

Conversation

Leont
Copy link
Contributor

@Leont Leont commented Jan 15, 2025

This fixes a flaw in 29b0ccb that causes warnings about these macros being redefined when PERL_WANT_VARARGS is defined on a multiplicity perl.

@Leont
Prevent double definitions of vararg functions
48d56f3 
This fixes a flaw in 29b0ccb that
causes warnings about these macros being redefined.
@Leont
Copy link
Contributor Author

Leont commented Jan 15, 2025

Example

@jkeenan
Copy link
Contributor

jkeenan commented Jan 16, 2025

Example

The perl -V info on that CPANtesters report doesn't say anything about PERL_WANT_VARARGS. Can you say why that variable (?) is relevant here? Thanks.

@Leont
Copy link
Contributor Author

Leont commented Jan 16, 2025

The perl -V info on that CPANtesters report doesn't say anything about PERL_WANT_VARARGS. Can you say why that variable (?) is relevant here? Thanks.

PERL_WANT_VARARGS is something you'd define on a XS module not when building core, e.g. here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leont @jkeenan