doio: fix shmread() on non-string buffers #22900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If the buffer is a reference, don't leak memory (or abort, on debugging perls). The problem is that SvPOK_only() blindly turns off some SV flags, but does not decrement any refcounts if ROK was on. - If the buffer is tied, don't call FETCH. Conceptually, shmread() is a bytestring assignment (from a shared memory segment to a scalar variable), so it should only STORE. (This is also why most of the code can be replaced by sv_setpvn().) Fixes Perl#22898.
tonycoz
approved these changes
Jan 9, 2025
|
I suspect this behaved badly with COW SVs too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22898.