builtin: avoid passing bad parent argument to op_sibling_splice #22874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
op_sibling_splice() is supposed to be called with a parent/child op pair as the first two arguments. But in `op_sibling_splice(parent, pushop, 1, NULL)`, `parent` is not necessarily a parent of `pushop`; it can also be a grandparent. In practice, this is harmless, however, as the parent argument is only used when splicing the first or last sibling of an op chain, which is never the case here (as ensured by the `argop` checks). So just avoid `parent` altogether and pass `NULL` as the first argument instead, which is a documented part of the op_sibling_splice() API (and will raise a proper error if our assumptions don't hold in the future).
iabyn
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
op_sibling_splice() is supposed to be called with a parent/child op pair as the first two arguments. But in
op_sibling_splice(parent, pushop, 1, NULL),parentis not necessarily a parent ofpushop; it can also be a grandparent. In practice, this is harmless, however, as the parent argument is only used when splicing the first or last sibling of an op chain, which is never the case here (as ensured by theargopchecks).So just avoid
parentaltogether and passNULLas the first argument instead, which is a documented part of the op_sibling_splice() API (and will raise a proper error if our assumptions don't hold in the future).