-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build.yml #169
Closed
Closed
Update build.yml #169
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,27 @@ | ||
| name: Build | ||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| package_name: | ||
| description: "Package name of the game:" | ||
| required: true | ||
| 姓名:建立 | ||
| 在……之上: | ||
| workflow_dispatch: | ||
| 输入: | ||
| package_name: | ||
| 描述:"com.tencent.tmgp.pubgmhd：" | ||
| 必需的:正确 | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-java@v3 | ||
| with: | ||
| distribution: temurin | ||
| java-version: 11 | ||
| cache: gradle | ||
| - run: | | ||
| chmod +x ./gradlew | ||
| sed -i 's/moduleDescription = "/moduleDescription = "(${{ github.event.inputs.package_name }}) /g' module.gradle | ||
| sed -i "s/com.game.packagename/${{ github.event.inputs.package_name }}/g" module/src/main/cpp/game.h | ||
| ./gradlew :module:assembleRelease | ||
| - uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: zygisk-il2cppdumper | ||
| path: out/magisk_module_release/ | ||
| 工作: | ||
| 建立: | ||
| run-on:ubuntu-最新 | ||
| 步骤: | ||
| -uses:操作/签出@v3 | ||
| -uses:操作/设置-java@v3 | ||
| 和……一起: | ||
| 分布:temurin | ||
| java版:11 | ||
| 缓存:Gradle | ||
| -跑:| | ||
| chmod+x./gradlew | ||
| SED-i的/moduleDescription="/moduleDescription="(${{github。event.inputs.package_name}})/g'module.gradle | ||
| SED-i"s/com.game.packagename/${{github.event.inputs.package_name}}/g"模块/src/main/cpp/Game.h | ||
| ./gradlew：模块：assemblyRelease | ||
| -uses:操作/上载工件@v3 | ||
| 和……一起: | ||
| 姓名:zygisk-il2cppdumper | ||
| 路径:out/magisk_module_release/ | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
对照了一下所有被翻译的内容，正常情况下这可能是整个PR唯一变更了的行，只是添加一个包名
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
支持正义淘金
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
支持🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不太明白他加一个和平精英包名在这里干什么
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See README, to use this repo need to add this line in action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zygisk-Il2CppDumper/README.zh-CN.md
Lines 7 to 13 in ede65d1
因为这个项目需要指定游戏软件的包名然后对这个包名对应的游戏的包跑处理
（还因为我刚刚才看到README是什么，原来这个是应该在fork了以后的本地分支做的，这个仓库是一个”模板“。那这位 老哥/老姐 的迷惑程度就更加一层了，你闲的没事来改模板仓库干嘛（虽然我知道您这绝对是误操作，而且还是不止一个误操作叠起来的））
怎么说呢，面对新人还是要尽量不要嘲讽的指出错误吧，毕竟我们也有是新人的时候（虽然我也好想开团吐槽啊！！！真的太绷不住了！！！
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
所以明明该根据自己需求fork这个仓库并且在他的分支里面加包名，却提了个pr到模板仓库还“汉化”，更难崩了
感觉像是玩和平精英想用模块作弊的，结果连GitHub都没玩明白There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
试了一下，按readme说的到action里run的时候直接输入包名显然不会对代码有任何变更，更迷惑了。
game.h的那堆PR倒还算，理解
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
难绷 想起之前lsp框架
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你是对的