-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ldap.py for parse_result_attributes #471
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: termanix <[email protected]>
Signed-off-by: termanix <[email protected]>
Signed-off-by: termanix <[email protected]>
Signed-off-by: termanix <[email protected]>
Signed-off-by: termanix <[email protected]>
Signed-off-by: termanix <[email protected]>
Signed-off-by: termanix <[email protected]>
Signed-off-by: termanix <[email protected]>
Signed-off-by: termanix <[email protected]>
Signed-off-by: termanix <[email protected]>
Signed-off-by: termanix <[email protected]>
Only gmsa left. Can't test it yet. It can be review for now. |
The errors I've encountered on ldap_results.py. Important Note: Same error in ldap_results.py in the current main iirc and #441 ldap_results.py . This bug was fixed in #381. After merging #441 #381, this PR should be checke and review with the new ldap_results.py.
After fix ldap_results.py, other bug-fixes on ldap.py
[Before fix]. Top SID value was coming from
[Before fix]. To display non-printable characters, such as
[Before Fix] All admin accounts and groups are displaying with the currently running code. But After parsing it does display only accounts. [After Fix] In the old code, if there was no attributes value, an empty value was assigned and append was performed. Relevant sections for this were added to the new code. This correction was then made to all similar flags 26391a3.
|
This PR was opened in ldap.py to handle all parse_result_attributes operations, and PR 441 was opened to avoid overlapping some changes. Relevant changes will occur slowly and with frequent checks.