Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfixes: add-computer & nanodump modules #237

Merged
merged 4 commits into from
Apr 5, 2024
Merged

bugfixes: add-computer & nanodump modules #237

merged 4 commits into from
Apr 5, 2024

Conversation

Marshall-Hallenbeck
Copy link
Collaborator

  • remove exit(1) calls from add-computer as it was "failing" tests, even though there were no programmatic failures
  • properly pass in logger to MSSQL execution (not sure how this didn't come up before, does no one use this?)

@Marshall-Hallenbeck Marshall-Hallenbeck added the bug-fix This Pull Request fixes a bug label Mar 29, 2024
@Marshall-Hallenbeck Marshall-Hallenbeck self-assigned this Mar 29, 2024
@NeffIsBack
Copy link
Contributor

exit(1) should be replaced with return or not? Otherwise it will probably crash if there is the assumption that some variable exists

@Marshall-Hallenbeck
Copy link
Collaborator Author

By default python returns (0)

@Marshall-Hallenbeck
Copy link
Collaborator Author

@NeffIsBack readded the exit(1)s to the module options as we discussed

NeffIsBack
NeffIsBack reviewed Apr 1, 2024
View reviewed changes
nxc/modules/add-computer.py Show resolved Hide resolved
nxc/modules/add-computer.py Show resolved Hide resolved
NeffIsBack
NeffIsBack approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@NeffIsBack NeffIsBack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Marshall-Hallenbeck Marshall-Hallenbeck merged commit 9359ac2 into main Apr 5, 2024
9 checks passed
@Marshall-Hallenbeck Marshall-Hallenbeck deleted the marshall-bugfix-3292024 branch April 5, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeffIsBack NeffIsBack NeffIsBack approved these changes

@zblurx zblurx Awaiting requested review from zblurx zblurx is a code owner

@mpgn mpgn Awaiting requested review from mpgn mpgn is a code owner

Assignees

@Marshall-Hallenbeck Marshall-Hallenbeck

Labels
bug-fix This Pull Request fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Marshall-Hallenbeck @NeffIsBack