Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support array-type metadata fields in cubids group #407

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jan 17, 2025

Closes #281 and closes #331.

A few things to look into

  • Fields that are arrays for some subjects and floats for others (e.g., RepetitionTimeExcitation can be either).
  • Is the dataframe saved and loaded back into memory at any point? If so I need to find where and use the new utility functions I wrote.
  • I think I need to update round_params() too.
  • Any other places where metadata fields are compared?

Changes proposed in this pull request

  • Allow lists in the param_group_df parameter to cubids.cubids.format_params()
    • Fields with "tolerance" in the config will be fed into the AgglomerativeClustering step, but only after splitting and grouping by the length of the arrays.
    • Fields without "tolerance" will be converted to a string and compared based on that.

@tsalo tsalo added the enhancement New feature or request label Jan 17, 2025
@mattcieslak
Copy link
Contributor

This is a very smart approach to the problem. I think it will work.

I don't think any of the dataframes will ever be written and reloaded during the course of a command line call.

@tsalo tsalo marked this pull request as ready for review January 29, 2025 20:50
@tsalo
Copy link
Member Author

tsalo commented Jan 29, 2025

@mattcieslak do you want me to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to add ShimSetting to config.yml doesn't work Support array-type metadata fields
2 participants