-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation #290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
is an optional dependency of ``CuBIDS``, we use it here to demonstrate its | ||
powerful integration with ``CuBIDS`` and the benefits it can provide its users. | ||
conda environment titled "cubids". | ||
In this example, we use validator version ``1.7.2``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how behind is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Roughly 3 years old. Probably a good idea to update the example and notebooks at some point.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
==========================================
+ Coverage 62.02% 62.13% +0.11%
==========================================
Files 8 9 +1
Lines 1572 1582 +10
==========================================
+ Hits 975 983 +8
- Misses 597 599 +2 ☔ View full report in Codecov by Sentry. |
Closes none. One slightly, but not meaningfully, breaking change is that the
CuBIDS
class is no longer accessible throughcubids
(i.e., you can't dofrom cubids import CuBIDS
). Instead, you need the submodule now (from cubids.cubids import CuBIDS
).Changes proposed: