feat: add inputs to tx type #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klakurka
previously approved these changes
Jan 12, 2025
chedieck
requested changes
Jan 13, 2025
react/lib/util/types.ts
Outdated
| @@ -15,6 +15,7 @@ export interface Transaction { | |||
| timestamp: number | |||
| address: string | |||
| rawMessage?: string | |||
| inputAddresses?: (string | undefined)[] | |||
There was a problem hiding this comment.
Same thing I commented in the server PR: I don't see the sense into having undefined as a possibility here.
chedieck
approved these changes
Jan 17, 2025
Klakurka
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #444
Description
Added input addresses to Transaction type
Test plan