Skip to content

Commit

Permalink
Mirror: Per-department wire layouts (Vault-Overseers#285)
Browse files Browse the repository at this point in the history
## Mirror of PR #26247: [Per-department wire
layouts](space-wizards/space-station-14#26247)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)

###### `670a9826fec9627ffdbee69742a881dab3606fa1`

PR opened by <img
src="https://avatars.githubusercontent.com/u/47712032?v=4"
width="16"/><a href="https://github.com/Killerqu00"> Killerqu00</a> at
2024-03-18 21:09:54 UTC

---

PR changed 2 files with 208 additions and 0 deletions.

The PR had the following labels:
- Status: Needs Review


---

<details open="true"><summary><h1>Original Body</h1></summary>

> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
> 
> ## About the PR
> Wire layouts for airlocks are now only same inside a single
department. Wire layouts for different department airlocks are
different.
>  ~~Also, airlocks now generally have more wires.~~
> 
> ## Why / Balance
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
> See Discord discussions and feedback regarding MRP hacking
clarifications:
>
https://ptb.discord.com/channels/310555209753690112/1217557314328854628/1217779616828231691
> 
> ## Technical details
> <!-- If this is a code change, summarize at high level how your new
code works. This makes it easier to review. -->
> Made some WiresSystem.cs changes, fixing code that broke inheritance.
> 
> ## Media
> <!-- 
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
> 
> If you're unsure whether your PR will require media, ask a maintainer.
> 
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
>
![image](https://github.com/space-wizards/space-station-14/assets/47712032/476f5ff2-725b-481b-9805-421078905590)
>
![image](https://github.com/space-wizards/space-station-14/assets/47712032/0ba49109-86f8-4bcf-8e59-d87b2989fc12)
> 
> 
> - [X] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
> 
> ## Breaking changes
> <!--
> List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
> -->
> 
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
> 
> 🆑
> - tweak: Airlock wires are now different between departments.
> 


</details>

---------

Co-authored-by: SimpleStation14 <Unknown>
Co-authored-by: VMSolidus <[email protected]>
  • Loading branch information
SimpleStation14 and VMSolidus authored May 29, 2024
1 parent 5c2cff0 commit b61bdca
Show file tree
Hide file tree
Showing 2 changed files with 208 additions and 1 deletion.
Loading

0 comments on commit b61bdca

Please sign in to comment.