Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash caused by lack of envirement override propagation #8392

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Fix crash caused by lack of envirement override propagation #8392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Modules/CalcSetup.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,7 @@ function calcs.initEnv(build, mode, override, specEnv)
env.calcsInput = build.calcsTab.input
env.mode = mode
env.spec = override.spec or build.spec
env.override = override
env.classId = env.spec.curClassId

modDB = new("ModDB")
Expand Down
2 changes: 0 additions & 2 deletions src/Modules/Calcs.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,6 @@ function calcs.getMiscCalculator(build)
end
return function(override, useFullDPS)
local env, cachedPlayerDB, cachedEnemyDB, cachedMinionDB = calcs.initEnv(build, "CALCULATOR", override)
-- we need to preserve the override somewhere for use by possible trigger-based build-outs with overrides
env.override = override
calcs.perform(env)
if (useFullDPS ~= false or build.viewMode == "TREE") and usedFullDPS then
-- prevent upcoming calculation from using Cached Data and thus forcing it to re-calculate new FullDPS roll-up
Expand Down
Loading