Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More small stuff #375

Merged
merged 3 commits into from
Nov 8, 2023
Merged

More small stuff #375

merged 3 commits into from
Nov 8, 2023

Conversation

brownbaerchen
Copy link
Contributor

This PR includes small fixes and a convergence controller that can abort a run when it exceeds a certain runtime. This was useful to me because some faults would trigger weird behaviour leading to tiny step sizes in adaptive time stepping, or when doing work precision plots I could go to very high precision without needing to consider if this would run before the sun swallows us. Maybe it's useful for someone else as well.

There is still the issue that black removes more blank lines in the CI pipeline than locally on my laptop. If anyone finds a solution, please tell me about it!

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (36e06fe) 73.95% compared to head (d43110f) 73.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage   73.95%   73.93%   -0.02%     
==========================================
  Files         271      271              
  Lines       22456    22481      +25     
==========================================
+ Hits        16607    16622      +15     
- Misses       5849     5859      +10     
Files Coverage Δ
pySDC/core/ConvergenceController.py 88.88% <100.00%> (+0.46%) ⬆️
...onvergence_controller_classes/check_convergence.py 84.21% <40.00%> (-0.98%) ⬇️
...controller_classes/interpolate_between_restarts.py 92.68% <78.57%> (-7.32%) ⬇️
...mentations/convergence_controller_classes/crash.py 86.36% <86.36%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pancetta pancetta merged commit 3e572aa into Parallel-in-Time:master Nov 8, 2023
23 of 25 checks passed
@brownbaerchen brownbaerchen deleted the merge1 branch November 8, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants