Test for DiscontinuousTestODE #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #368 +/- ##
==========================================
+ Coverage 72.55% 72.56% +0.01%
==========================================
Files 269 269
Lines 22330 22328 -2
==========================================
+ Hits 16202 16203 +1
+ Misses 6128 6125 -3
☔ View full report in Codecov by Sentry. |
| u_event = DODE.u_exact(DODE.t_switch_exact) | ||
| h = u_event[0] - 5 | ||
|
|
||
| assert h < 1e-15, 'Value of state function at exact event time is not zero!' |
There was a problem hiding this comment.
Maybe you should test for the absolute value of h here.
|
|
||
| sol = DODE.solve_system(**args) | ||
| assert np.isclose( | ||
| sol[0], DODE.u_exact(t0 + dt)[0], atol=2e-3 |
There was a problem hiding this comment.
Why don't you use np.allclose and test all of the values instead of just the first one?
There was a problem hiding this comment.
Your are right, but in this case, the solution consists of only one value.
|
Ready to be merged? |
|
From my side, yes. Depends on @brownbaerchen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since hardcoded solutions do not say anything about the correctness of the problem class itself, I also added a small test for the
DiscontinuousTestODE. It's only a small one whether the correct event time together with value of state function at event is tested. In the TIME-X test hackathon I also learnt that errors can be tested by capture them. Thus,ProblemErrorandlogger.warningare also captured through this test whennanvalues arises.The function
get_switching_infois not tested here, because this is rather stuff ofSwitchEstimatorwhich I also started to test during the test hackathon. (Coming soon some time..)Let me know if this is not enough.