Lazarus Reagent no longer forces you Alive #28011
Open
+46
−30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
This changes Lazarus Reagent to behave more like a chemical version of defibrillators; it will give the ghost a notification that their body has Lazarus reagent in it, and if they return to their body, they will be revived. It also gives feedback in cases where this would fail or can't succeed.
It was once implemented this way here #18910 and was reverted here #19089 due to bugs.
I would like to prefix everything here with the fact that these are my most extensive changes to date, and with a history of how changes like this have not worked well on live before, a TM will likely be needed.
This would also resolve #27822 which is what first sent me down the rabbit hole.
Why It's Good For The Game
Not being "SUDDENLY ALIVE" is good, and should stop rare edge cases where LR revives someone and they are catatonic.
Testing
I have tested these changes locally and they appear to work just fine, I shall do more extensive testing and add relevant evidence below.
Below is a quick video of LR in action.
lrtest2min_no_audio.mp4
Declaration
Changelog
🆑
tweak: LR revival is now voluntary.
/:cl: