Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazarus Reagent no longer forces you Alive #28011

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Erikos66
Copy link
Contributor

@Erikos66 Erikos66 commented Jan 17, 2025

What Does This PR Do

This changes Lazarus Reagent to behave more like a chemical version of defibrillators; it will give the ghost a notification that their body has Lazarus reagent in it, and if they return to their body, they will be revived. It also gives feedback in cases where this would fail or can't succeed.

It was once implemented this way here #18910 and was reverted here #19089 due to bugs.

I would like to prefix everything here with the fact that these are my most extensive changes to date, and with a history of how changes like this have not worked well on live before, a TM will likely be needed.

This would also resolve #27822 which is what first sent me down the rabbit hole.

Why It's Good For The Game

Not being "SUDDENLY ALIVE" is good, and should stop rare edge cases where LR revives someone and they are catatonic.

Testing

I have tested these changes locally and they appear to work just fine, I shall do more extensive testing and add relevant evidence below.

  • Works in Pill AND liquid form
  • Doesn't out changelings
  • Doesn't work on suicidees
  • Repeat attempts still work

Below is a quick video of LR in action.

lrtest2min_no_audio.mp4

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

image

Changelog

🆑
tweak: LR revival is now voluntary.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Jan 17, 2025
@autocephalophagy
Copy link

will it still gib if the person has enough damage, regardless if they are in their body?

@Erikos66
Copy link
Contributor Author

will it still gib if the person has enough damage, regardless if they are in their body?

Yes, it will still gib people who have a total of 150 damage. Regardless if there in the body or out.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally labels Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lazarus Reagent forces people back into their body
4 participants