Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Great Fire Extinguisher Refactor #28005

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Fordoxia
Copy link
Contributor

What Does This PR Do

Migrates fire extinguishers, firefighter backpack tanks, and the atmos MODsuit firefighter module to the new attack chain.

Refactors the above - modsuit module especially is now a subtype of the backpack module.

Atmos backpack now benefits from changing nozzle sprites.

Why It's Good For The Game

The attack chain migration shall continue until morale improves.

Removes a respectable chunk of duplicated code.

The fine control of the new attack chain means you no longer bludgeon people when you are trying to extinguish them, hooray!

Backpack nozzle icon buff is good.

Testing

Put a fire extinguisher on Ian, they were able to fill it as normal.

Equipped regular and mini extinguishers. Spray function worked as expected. Did not attack unless nozzle was put away.

Equipped backpack firefighter tank. Cycled through all modes and tested them. Retracted nozzle. Worked as expected.

Equipped modsuit nozzle, repeated above. Retracted nozzle. Worked as expected.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
tweak: Backpack firefighter tank nozzle sprite now changes when changing modes, as the modsuit version does.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jan 16, 2025
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Jan 18, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Merge Conflict This PR is merge conflicted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants