The Great Fire Extinguisher Refactor #28005
Open
+143
−167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Migrates fire extinguishers, firefighter backpack tanks, and the atmos MODsuit firefighter module to the new attack chain.
Refactors the above - modsuit module especially is now a subtype of the backpack module.
Atmos backpack now benefits from changing nozzle sprites.
Why It's Good For The Game
The attack chain migration shall continue until morale improves.
Removes a respectable chunk of duplicated code.
The fine control of the new attack chain means you no longer bludgeon people when you are trying to extinguish them, hooray!
Backpack nozzle icon buff is good.
Testing
Put a fire extinguisher on Ian, they were able to fill it as normal.
Equipped regular and mini extinguishers. Spray function worked as expected. Did not attack unless nozzle was put away.
Equipped backpack firefighter tank. Cycled through all modes and tested them. Retracted nozzle. Worked as expected.
Equipped modsuit nozzle, repeated above. Retracted nozzle. Worked as expected.
Declaration
Changelog
🆑
tweak: Backpack firefighter tank nozzle sprite now changes when changing modes, as the modsuit version does.
/:cl: