Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meteor shielding improvements #27996

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FunnyMan3595
Copy link
Contributor

What Does This PR Do

Meteors now appear at the edge of the map (beyond the buildable range), rather than so close they can bypass shield satellites.
Emagged shield satellites are now clever and shoot down simulated meteors.
Shield sats inside a crate now report the crate's position on the control map, rather than the corner of the map.

Why It's Good For The Game

Makes the shields work better, emagged sats not tell on themselves, and fixes a bug.

Testing

Spawned meteors. They flew normally, but from the map edge.
Threw meteors at emagged and non-emagged shield sats. Emagged ones didn't fire.
Simulated a meteor wave. Emagged sats reported shooting down meteors.
Looked at a crate on the shield sat map.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
tweak: Meteors now appear at the edge of the map (beyond the buildable range), rather than so close they can bypass shield satellites.
tweak: Emagged shield satellites are now clever and shoot down simulated meteors.
fix: Shield sats inside a crate now report the crate's position on the control map, rather than the corner of the map.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally labels Jan 16, 2025
@FunnyMan3595 FunnyMan3595 added the Tweak This PR tweaks something ingame label Jan 17, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Tweak This PR tweaks something ingame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants