Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes abstract items showing on mob examine #27951

Merged
merged 2 commits into from
Jan 12, 2025

Conversation

Qwertytoforty
Copy link
Contributor

What Does This PR Do

Fixes abstract items showing on mob examine by moving the trait_skip_examine up so the else doesnt falsely trigger

Why It's Good For The Game

Abstract items should not show on examine
skip examine items should still not show on examine

Testing

Equipped abstract nullrod.
Did not show on examine, did show the fleshy arm message
Made a non abstract item have TRAIT_SKIP_EXAMINE
Did not show on examine still


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
fix: Fixes abstract items showing on mob examine
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Jan 12, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jan 12, 2025
Co-authored-by: DGamerL <[email protected]>
Signed-off-by: Qwertytoforty <[email protected]>
@DGamerL DGamerL added this pull request to the merge queue Jan 12, 2025
Merged via the queue into ParadiseSS13:master with commit a4a92f7 Jan 12, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants