Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize Atmospherics much faster #27862

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Conversation

FunnyMan3595
Copy link
Contributor

@FunnyMan3595 FunnyMan3595 commented Jan 6, 2025

What Does This PR Do

Inverts how MILLA gets the initial map from DM sending it to MILLA requesting it. This is a massive increase in speed, because we can do the entire process in native code. All that remains in DM is a bit of necessary setup work.

Why It's Good For The Game

Init times go brr.

Testing

Loaded in fine.
Airs were normal in enclosed tiles, lavaland-exposed tiles, and space.
Atmos tanks were also filled as usual.
Shuttles were able to load in properly.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
del: About 10 seconds of server start time.
/:cl:

@FunnyMan3595
Copy link
Contributor Author

!build_rust

Copy link
Member

@AffectedArc07 AffectedArc07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shaves like 10 seconds off.

@FunnyMan3595 FunnyMan3595 added the Performance This will increase performance on the server label Jan 7, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Jan 7, 2025
Copy link
Member

@Burzah Burzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shaves like 10 seconds off.

DHL's Fastest Lap Award 2025

@DGamerL DGamerL added this pull request to the merge queue Jan 7, 2025
Merged via the queue into ParadiseSS13:master with commit 24f6787 Jan 7, 2025
17 checks passed
m-dzianishchyts added a commit to m-dzianishchyts/Paradise-SS220 that referenced this pull request Jan 12, 2025
m-dzianishchyts added a commit to m-dzianishchyts/Paradise-SS220 that referenced this pull request Jan 12, 2025
m-dzianishchyts added a commit to m-dzianishchyts/Paradise-SS220 that referenced this pull request Jan 12, 2025
m-dzianishchyts added a commit to m-dzianishchyts/Paradise-SS220 that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Performance This will increase performance on the server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants