Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buff mining mod from vendor #27825

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kyunkyunkyun
Copy link
Contributor

What Does This PR Do

Buffs mining mod for miners by making it full packaged when buying from vendor + all mining mods (e.g. from ruins) now carry an expanded capacity storage.

Why It's Good For The Game

Mod for 3500 mining points gives you.. default storage and thats all. However a standard (explorer) mod for 1000 pts gives you a large capacity storage, welding shield module, jetpack. Kinda unfair to miners + explorers have the mod by roundstart.

There was a comment "visit robotics to get the modules" in the code, but you still would like to visit robotics to get the medical hud, thermal regulation, holster, welding shield or a syndie storage.

A default version only has all needed for a miner to.. "mine", the rest are up to those who would like to get the max of their modsuit. After all, you are wasting 3500 pts on that.

Testing

Bought one on local, ensured the modules are in.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
tweak: Mining mod from vendor now goes full packaged, as well as all mining mods now have a large capacity storage by default.
/:cl:

@Fordoxia
Copy link
Contributor

Fordoxia commented Jan 4, 2025

The rest of the modules are understandable, but you don't actually need expanded storage to mine as a miner.

@kyunkyunkyun
Copy link
Contributor Author

you don't actually need expanded storage to mine as a miner.

k, yeah, that's more of a qol change so you don't have to waste another 1000 pts to remove expanded storage from explorer modsuit

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting approval This PR is waiting for approval internally label Jan 5, 2025
@RufusVanilee
Copy link
Contributor

There should be a reason for modsuits needing robotics, if modsuits had everything that they needed off of purchasing them, then there would be less of a reason for their department.

@Komrad822
Copy link
Contributor

Agree with Rufus

@kyunkyunkyun
Copy link
Contributor Author

There should be a reason for modsuits needing robotics, if modsuits had everything that they needed off of purchasing them, then there would be less of a reason for their department.

But as i said there is still a reason to visit 'em, a lot of miners do want to get the medical hud (module does it without any surgery), also you might get a thermal regulation module, which hepls you significantly against watchers, holster module for the KA (or at least cutter, which might go to the shoulder holster), syndie storage for +3 normal-sized slots, welding shield module to be more flexible with the modsuit active.

The reason i try to do this is because not every round you have a robotics that will help you, like there might be no robo at all (low population rounds), or they might be busy constructing combat mecha, repairing IPCs, they might be antags and all stuff like that.

You will visit robotics to get new modules, or get the slime core + slime oil potion to make the most of the mod even after the changes. Currently the mod is just nonsense compared to the explorer's one, which is going full-packaged without any needs to visit robotics. However, whenever i play explorer, i do visit robo to get a lot of extra modules and reach a limit of my modsuit's complexity!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting approval This PR is waiting for approval internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants