[FIX] Better slices

[Drsmail]

What Does This PR Do

• Adds a new subtype /obj/item/food/slice to ensure similar slice behavior
• Refactor a bunch of food subtypes form food/margaritapizzaslice to food/slice/margarita_pizza

Why It's Good For The Game

There will not be a slices with 0 reagents on maps

Testing

Built and runed.

---

Declaration

• I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

  ---

Changelog

🆑
Fix: All food slices on maps have nutritional values.
Tweak: Some sliceable food nutritional values have been increased, so the slices contain a whole amount of reagents.
/:cl:

[Drsmail]

This line pizza = new pizza_type(src) in code\modules\food_and_drinks\food\foods\pizza.dm cause CRACH to trigger, i have no idea how to handle this.

/obj/item/food/sliceable/Initialize(mapload)
	if(!istype(slice_path, /obj/item/food/slice))
		CRASH("Invalid type assigned to slice_path: [slice_path]")
	return ..()

Also there is steal some slices that are used by maps, but don't have a reagent list. For example:

/obj/item/food/slice/bread
	name = "bread slice"
	desc = "A slice of home."
	list_reagents = list("nutriment" = 2, "bread" = 5) // has it!
	tastes = list("bread" = 1)

/obj/item/food/slice/pumpkinpie
	name = "pumpkin pie slice"
	desc = "A slice of pumpkin pie, with whipped cream on top. Perfection."
	icon = 'icons/obj/food/bakedgoods.dmi'
	// does not have it!
	tastes = list("pie" = 1, "pumpkin" = 1)

How this should be handled?
@DGamerL

[FunnyMan3595]

Needs those two files reverted, otherwise seems fine.

[Drsmail]

Needs those two files reverted, otherwise seems fine.

Done

[DGamerL]

Please remove this, in case someone wants to add a non-sliced food as a result

[Drsmail]

I will remove this

[DGamerL]

Suggested change

	if(made_by_sliceable)
	return ..()
	if(made_by_sliceable)
	list_reagents = list()
	return ..()

[Drsmail]

This will be called from here -> var/obj/slice = new slice_path (loc, TRUE)
That means we are sliced normally and we have a 'parent', all reagents calculations were handled.
This is why we return.

if(made_by_sliceable)
		return ..()

Anyway, we have var/list/list_reagents = list() from /obj/item/food.
So what was the reason for changes? What do you want to change?

[Drsmail]

@DGamerL How do i handle changes after PR got merged? Do i create a new one?