-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes Vampire From Explorer #27589
Removes Vampire From Explorer #27589
Conversation
Your PR has been put on hold as your GitHub account is not linked to a Paradise forums account. Please link your account at https://www.paradisestation.org/forum/custom/link_github_account.php Headcoders may ignore this in specific circumstances (Minor fix PR, trusted contributor from another codebase, anything at their discretion) |
Account has been linked. |
@@ -2,7 +2,7 @@ | |||
name = "traitor_vampire" | |||
config_tag = "traitorvamp" | |||
traitors_possible = 3 //hard limit on traitors if scaling is turned off | |||
protected_jobs = list("Security Officer", "Warden", "Detective", "Head of Security", "Captain", "Blueshield", "Nanotrasen Representative", "Magistrate", "Internal Affairs Agent", "Nanotrasen Navy Officer", "Special Operations Officer", "Trans-Solar Federation General") | |||
protected_jobs = list("Security Officer", "Warden", "Detective", "Head of Security", "Captain", "Blueshield", "Nanotrasen Representative", "Magistrate", "Internal Affairs Agent", "Nanotrasen Navy Officer", "Special Operations Officer", "Trans-Solar Federation General", "Explorer") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will block traitors from being explorers, but not vampires.
…t carries over properly
Wouldn't this also cause IPC explorers to be unable to roll mindflayer half the time? |
antag rolls before job. you wont be able to be an explorer sometimes though as IPC. Also, this will affect clings because of how poorly gamemodes are coded |
!wiki_label |
Alas, forgot to comment it on here, though did on discord. |
Access is important and explorer is one of the only non-head job that grants access to the main station teleporter which can be super useful (and hilariously detrimental) to an antag that can ONLY survive on tiles that shield them from the deadly laser that is the sun. Its not needed and vamp doesnt lose out on gear depending on their job like tots do with department specific items. |
I honestly don't see much point in blacklisting the role from that antag type, you can either change roles at HoP if you really don't feel comfortable or as Komrad pointed out, actually utilise the extra access you have. |
I will be closing this PR at this time, as it is now past the 30 day time period and has failed the vote. Listed below are objections registered by both the balance and design teams. If you have any questions, please reach out to the members of this team or any maintainer.
|
What Does This PR Do
Removes vampires from explorer by adding them to the protected_jobs list.
Why It's Good For The Game
Vampires are unable to do their role as an explorer via reasonable means, leaving them to just roam the station like an assistant with teleporter access. If they were to even attempt going to where this job requires them to, they will be round removed.
Testing
To be conducted.
Declaration
Changelog
🆑
add: added explorer to protected_jobs
/:cl: