Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Vampire From Explorer #27589

Closed

Conversation

RufusVanilee
Copy link
Contributor

@RufusVanilee RufusVanilee commented Dec 8, 2024

What Does This PR Do

Removes vampires from explorer by adding them to the protected_jobs list.

Why It's Good For The Game

Vampires are unable to do their role as an explorer via reasonable means, leaving them to just roam the station like an assistant with teleporter access. If they were to even attempt going to where this job requires them to, they will be round removed.

Testing

To be conducted.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
add: added explorer to protected_jobs
/:cl:

@ParadiseSS13-Bot
Copy link
Contributor

Your PR has been put on hold as your GitHub account is not linked to a Paradise forums account.

Please link your account at https://www.paradisestation.org/forum/custom/link_github_account.php

Headcoders may ignore this in specific circumstances (Minor fix PR, trusted contributor from another codebase, anything at their discretion)

@ParadiseSS13-Bot ParadiseSS13-Bot added the On Hold Its gonna be a while before this is reviewed label Dec 8, 2024
@Burzah
Copy link
Member

Burzah commented Dec 8, 2024

Account has been linked.

@Burzah Burzah removed the On Hold Its gonna be a while before this is reviewed label Dec 8, 2024
@@ -2,7 +2,7 @@
name = "traitor_vampire"
config_tag = "traitorvamp"
traitors_possible = 3 //hard limit on traitors if scaling is turned off
protected_jobs = list("Security Officer", "Warden", "Detective", "Head of Security", "Captain", "Blueshield", "Nanotrasen Representative", "Magistrate", "Internal Affairs Agent", "Nanotrasen Navy Officer", "Special Operations Officer", "Trans-Solar Federation General")
protected_jobs = list("Security Officer", "Warden", "Detective", "Head of Security", "Captain", "Blueshield", "Nanotrasen Representative", "Magistrate", "Internal Affairs Agent", "Nanotrasen Navy Officer", "Special Operations Officer", "Trans-Solar Federation General", "Explorer")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will block traitors from being explorers, but not vampires.

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Dec 8, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Dec 8, 2024
@Scribble-Sheep
Copy link
Contributor

Wouldn't this also cause IPC explorers to be unable to roll mindflayer half the time?

@Contrabang
Copy link
Contributor

Wouldn't this also cause IPC explorers to be unable to roll mindflayer half the time?

antag rolls before job. you wont be able to be an explorer sometimes though as IPC.

Also, this will affect clings because of how poorly gamemodes are coded

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting review This PR is awaiting review from the review team labels Dec 9, 2024
@SynthTwo
Copy link
Contributor

!wiki_label

@github-actions github-actions bot added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Dec 19, 2024
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Dec 30, 2024
@Qwertytoforty
Copy link
Contributor

Alas, forgot to comment it on here, though did on discord.
Against this. Jobs should only be blocked if they cause issues for the gamemode, (HOP cult, chaplain vampire), and explorer doesnt meet that case. They can switch jobs, but also use the white ship and teleporters effectively, or the space bar.

@Komrad822
Copy link
Contributor

Access is important and explorer is one of the only non-head job that grants access to the main station teleporter which can be super useful (and hilariously detrimental) to an antag that can ONLY survive on tiles that shield them from the deadly laser that is the sun. Its not needed and vamp doesnt lose out on gear depending on their job like tots do with department specific items.

@Stoniest
Copy link
Contributor

Stoniest commented Jan 1, 2025

I honestly don't see much point in blacklisting the role from that antag type, you can either change roles at HoP if you really don't feel comfortable or as Komrad pointed out, actually utilise the extra access you have.

@Burzah
Copy link
Member

Burzah commented Jan 8, 2025

I will be closing this PR at this time, as it is now past the 30 day time period and has failed the vote. Listed below are objections registered by both the balance and design teams. If you have any questions, please reach out to the members of this team or any maintainer.

Against this. Jobs should only be blocked if they cause issues for the gamemode, (HOP cult, chaplain vampire), and explorer doesnt meet that case. They can switch jobs, but also use the white ship and teleporters effectively, or the space bar.

Access is important and explorer is one of the only non-head job that grants access to the main station teleporter which can be super useful (and hilariously detrimental) to an antag that can ONLY survive on tiles that shield them from the deadly laser that is the sun.

I honestly don't see much point in blacklisting the role from that antag type, you can either change roles at HoP if you really don't feel comfortable or as Komrad pointed out, actually utilise the extra access you have.

It was basically no different with old vampires with space shaft miners. Learn to work around your job with its positives and negatives.

I'm convinced by the others. While it's a bit of a newbie trap, there's no reason to lock them out of it.

Against this as stated above by others, you can request a new job and work or work around it but no need to blacklist them from it

The points raised by others are fair, we should reach out to the author about potentially closing the PR.

@Burzah Burzah closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting approval This PR is waiting for approval internally Merge Conflict This PR is merge conflicted Requires Wiki Update Useful for Wiki Contributers to search for things that need updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants