Improve CI output for legacy attack chain check #27587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AffectedArc07
approved these changes
Dec 8, 2024
ParadiseSS13-Bot
added
-Status: Awaiting type assignment
warriorstar-orion
added
the
Attack Chain Migration
ParadiseSS13-Bot
added
-Status: Awaiting merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
This PR improves the CI script for attack chain migrations to include filename and line number for aberrant proc declarations. This script is getting a little goofy and complicated but it only needs to last long enough to get across the finish line for the migration.
Why It's Good For The Game
Having filenames and line numbers here is much more easier to work with when checking the CI run.
Images of changes
Before:
After
Testing
Declaration
Changelog
NPFC