Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] RustG update #27264

Merged
merged 8 commits into from
Nov 9, 2024
Merged

Conversation

AffectedArc07
Copy link
Member

What Does This PR Do

Makes a para-specific TM of tgstation/rust-g#190

Pros include getting up to date on rustg and having some new library features.
Cons include redis maybe being unstable during TGS deployments.

This PR wont be merged since its not a proper para-rust-g fork yet, given it needs to be a proper RustG release.

Why It's Good For The Game

Updates good.

Testing

Started the server


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑 AffectedArc07
experiment: Someone merged a PR designed to be testmerged only. Find them and yell.
/:cl:

@AffectedArc07 AffectedArc07 added the Do Not Merge This PR must not be merged or closed label Nov 2, 2024
@AffectedArc07
Copy link
Member Author

CI wont run due to invalid lib version.

I can assure you server works though.
image

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Testmerge Active This PR is currently testmerged on production labels Nov 2, 2024
@AffectedArc07
Copy link
Member Author

Still fucked

image

@ParadiseSS13-Bot ParadiseSS13-Bot removed the Testmerge Active This PR is currently testmerged on production label Nov 2, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added Testmerge Active This PR is currently testmerged on production and removed Testmerge Active This PR is currently testmerged on production labels Nov 3, 2024
@AffectedArc07
Copy link
Member Author

Ive tried pinning the redis build back to 0.23, which was our old working one.

Time to now find out whether its the code in the library or an update to the lib.

@ParadiseSS13-Bot ParadiseSS13-Bot added Testmerge Active This PR is currently testmerged on production -Status: Awaiting review This PR is awaiting review from the review team and removed Testmerge Active This PR is currently testmerged on production -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Nov 4, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added the Testmerge Active This PR is currently testmerged on production label Nov 6, 2024
@AffectedArc07
Copy link
Member Author

Its been stable for just under 24 hours.

If it aint cried by Friday evening, its being finalised - and my ghetto notifier is being removed.

@AffectedArc07
Copy link
Member Author

Its been stable for just under 24 hours.

If it aint cried by Friday evening, its being finalised - and my ghetto notifier is being removed.

image

Its the library changes or the Pharos curse.

:aaaaaaaaaaaaaaaaaaaaaaaaaa:

@ParadiseSS13-Bot ParadiseSS13-Bot removed the Testmerge Active This PR is currently testmerged on production label Nov 7, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added the Testmerge Active This PR is currently testmerged on production label Nov 8, 2024
@AffectedArc07 AffectedArc07 changed the title [TM ONLY] RustG update [READY] RustG update Nov 9, 2024
@AffectedArc07 AffectedArc07 marked this pull request as ready for review November 9, 2024 20:54
@Burzah Burzah added this pull request to the merge queue Nov 9, 2024
Merged via the queue into ParadiseSS13:master with commit 1a2c836 Nov 9, 2024
12 checks passed
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Do Not Merge This PR must not be merged or closed Testmerge Active This PR is currently testmerged on production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants