Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power laser port 2 electric bogaloo #27171

Merged
merged 145 commits into from
Nov 25, 2024

Conversation

Migratingcocofruit
Copy link
Contributor

@Migratingcocofruit Migratingcocofruit commented Oct 22, 2024

What Does This PR Do

Ports the power transmission laser again, this time with 50% more description and 100% less broken behavior(let me dream okay).

The Power Transmission Laser sells the excess power produced by the station for credits.
Credits earned per cycle approach 0 as the output power approaches 0, and approaches 10 as the power output approaches infinity.
75% of the money generated goes to engineering, and the remaining 25% go to cargo.
The PTL will send money when it reaches 200 credits of stored funds so it doesn't spam the accounts with tiny transactions

The PTL will send updates as the station sends more and more energy to central, the threshold for a new announcement rises exponentially capped at 200GJ above the last one.

The PTL produces a beam that is purely visual now

The bore of the PTL will produce flashes from 5 MW of output power and up. The flash strength is output power in megawatts divided by 5 and capped by 3. Looking directly at the bore(opposite the direction of the PTL) gives the full flash effect, looking away from it gives no flash, and looking at it partly multiplies the flash strength by the cosine of the difference between the direction you're looking at and a line from you to the bore. The range scales with power in the same way and caps at 8 tiles away, and you can't get flashed while standing behind the bore(indicated by a black and yellow line in the PTL room)

Radiation starts at 30MW with the pulse strength being 50 times output power in megawatts divided by 30. This isn't capped, but should produce only a moderate amount of radiation even when outputting a gigawatt.

The PTL can be used to target megafauna in the mining base and it's immediate vicinity, dealing 10 * output in megawatts fire damage.
Megafauna damaged by the laser lose their loot, and megafauna that are killed by the laser also get dusted.
Once the targeted megafauna is dead the laser will automatically revert to selling power to central.

At the end of the round the total amount of energy exported by the PTL(in GigaJoules) is presented

PTL locations:

Cyberiad
image

Kerberos
image

Cerebron
image

Farragus
image

Diagoras
image

Why It's Good For The Game

Allows engineers to do something with all the power they make.

Images of changes

380451347-0a939632-d3f6-4bbb-8d63-fb12a1022d36
image

Testing

So far:

  • Observed the correct amount of payout being given at the correct threshold.
  • Ordered the PTL crate and used it to build one
  • Rotated the PTL and made sure it rotates when it should, and not when it shouldn't
  • Spawned lavaland mobs in the mining base and blasted them. They did not drop loot when they died.
  • Got flashed and irradiated by the PTL

ToDo

  • Make the blocker ref into a stored UID value.
  • Make fine adjustment better for low power use
  • Have max capacity not be infinite
  • Make the laser deconstructable and give it components and a cargo crate.
  • Add missing stuff to the rooms
  • Make the rooms not ugly
  • Get the PTL to show up properly on the map editor
  • Implement bombardment of megafauna close to the mining base
  • Delete megafauna loot if they are killed by the laser

Declaration

image

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
add: Ports the power transmission laser, a machine that sells the excess power produced by the station for credits
/:cl:

@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Nov 20, 2024
@Onyxarias
Copy link
Contributor

Currently placing a soft objection on this. The PR looks great from a Design point of view, but I would rather it not have so many broadcasted messages. Every other station goal doesn't do this except for sure emergencies. Instead, I'd like to see the messages restricted down to, say, just megafauna kills. Great work, by the way!

@Migratingcocofruit
Copy link
Contributor Author

Currently placing a soft objection on this. The PR looks great from a Design point of view, but I would rather it not have so many broadcasted messages. Every other station goal doesn't do this except for sure emergencies. Instead, I'd like to see the messages restricted down to, say, just megafauna kills. Great work, by the way!

I get what you mean, but I still want engineering to be able to show off. This is part of the point. Would changing the nature of the announcement be enough?

@Onyxarias
Copy link
Contributor

Currently placing a soft objection on this. The PR looks great from a Design point of view, but I would rather it not have so many broadcasted messages. Every other station goal doesn't do this except for sure emergencies. Instead, I'd like to see the messages restricted down to, say, just megafauna kills. Great work, by the way!

I get what you mean, but I still want engineering to be able to show off. This is part of the point. Would changing the nature of the announcement be enough?

While true, myself and others have found the constant messages rather annoying, and redundant. If you compare it to another engineering machine, the Supermatter, even that only outputs messages during critical emergencies or anomalies, and the latter is only on the engineering channel. As well, Cargo doesn't have computers loudhailing when they sell certain amounts of plasma.

If engineering REALLY wants to show off, the CE can use the station announcements to relay their accomplishments to the station; it's not something that needs to be done automatically and constantly.

Again, PR is great, and even with my objection will probably become another fantastic feature for a department that sorely needs it. But I don't think spamming the station's radio is a thing it should do.

@Migratingcocofruit
Copy link
Contributor Author

Currently placing a soft objection on this. The PR looks great from a Design point of view, but I would rather it not have so many broadcasted messages. Every other station goal doesn't do this except for sure emergencies. Instead, I'd like to see the messages restricted down to, say, just megafauna kills. Great work, by the way!

I get what you mean, but I still want engineering to be able to show off. This is part of the point. Would changing the nature of the announcement be enough?

While true, myself and others have found the constant messages rather annoying, and redundant. If you compare it to another engineering machine, the Supermatter, even that only outputs messages during critical emergencies or anomalies, and the latter is only on the engineering channel. As well, Cargo doesn't have computers loudhailing when they sell certain amounts of plasma.

If engineering REALLY wants to show off, the CE can use the station announcements to relay their accomplishments to the station; it's not something that needs to be done automatically and constantly.

Again, PR is great, and even with my objection will probably become another fantastic feature for a department that sorely needs it. But I don't think spamming the station's radio is a thing it should do.

If everything else was also doing it the radio would be unusable. Good point, that has me convinced. I'll be axing the announcements, and give some more info on the UI.

@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Nov 23, 2024
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Nov 23, 2024
@Burzah Burzah added this pull request to the merge queue Nov 25, 2024
Merged via the queue into ParadiseSS13:master with commit 7aeb174 Nov 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Feature This PR is a new addition to the game Map Edit This PR will modify a map Port This PR is from another server, or heavily inspired/adapted. Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Sprites This PR modifies the game sprites Testmerge Active This PR is currently testmerged on production Testmerge Requested This PR has a pending testmerge request TGUI This PR modifies TGUI, will conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants