Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increase radius of singulo movement target. #26789

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

warriorstar-orion
Copy link
Contributor

What Does This PR Do

This PR increases the radius around the target turf that a singularity moves towards, considering it successful if it gets within 2 tiles of the target. I'm calling this a fix because the behavior as written doesn't work as intended.

Why It's Good For The Game

Hitting a single tile with a randomly walking object is a crapshoot, especially if it only has a 20% chance to move towards it on any given tick. When the singulo can't manage to pin down its exact destination turf, it will instead be endlessly drawn to it, consuming the nearby station area and eventually running out of new things to consume.

Testing

Created singularities before and after, and observed them for 10 minutes. Observed that before this change, singulos would never hit their target despite coming within striking distance of it, and instead stick in a holding pattern around the target. Observed that after this change, singulos could hit their targets and select new ones.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
fix: Loose singulos more reliably pick new destinations when traveling.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Sep 15, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Sep 17, 2024
@DGamerL DGamerL added the Fix This PR will fix an issue in the game label Sep 25, 2024
@DGamerL DGamerL added this pull request to the merge queue Sep 25, 2024
Merged via the queue into ParadiseSS13:master with commit fbe77e2 Sep 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Fix This PR will fix an issue in the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants