-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPDs auto-wrenching #26775
RPDs auto-wrenching #26775
Conversation
Your PR has been put on hold as your GitHub account is not linked to a Paradise forums account. Please link your account at https://www.paradisestation.org/forum/custom/link_github_account.php Headcoders may ignore this in specific circumstances (Minor fix PR, trusted contributor from another codebase, anything at their discretion) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DM code looks good to me.
TGUI is witchcraft so I cannot comment on the code there.
If the BRPD can wrench remotely, I think it will be necessary to prevent it from working through walls (unless such a check exists already). Consider clings, who can get x-ray and turn into a ventcrawling monkey freely using abilities available roundstart, able to make a pre-wrenched vent pipe into any room they want. |
from what i know this'd be.. a task. unrelated to this, but im somewhat worried about people using the BRPD with the disposal bins to rapidly close up halls with wrenched bins |
This is also a concern with RPDs (which are currently able to auto-wrench with a wrench in hand). Even if no wrenching occurs (IIRC the unwrenched bins still have density. Also an issue with transit tube stations). One solution would be to just give it a 3-5 second do_after. Disposal bins are not placed very often, so it'd not really get in the way of making disposals rides or the like, but it WOULD stop you from spamming bins, much in the same way that holoprojectors and similar can't be spammed. Another potential solution (and one I prefer) is remove the density of unwrenched bins (if they have it, I forget), and make it so they cannot be wrenched unless there's a disposals trunk on the same tile. For transit stations, the screwdriver act already has a do_after, so ensuring it's not dense when secured would also be good. |
What Does This PR Do
Removes the wrench requirement for automatic wrenching
Allows BRPD to wrench down remotely
Adds a UI toggle for the automatic wrenching behaviour
Fixes transit tubes using the wrong tool act
Why It's Good For The Game
Allows the BRPD to be consistent with the RPD (and less useless) and makes auto-wrenching clearer for newer players!
Allows the BRPD to be turned into a cyborg module in a future PR
Images of changes
2024-09-14.16-58-24.mp4
Testing
Ensured the RPDs dont behave like wrenches outside of wrenching pipes down
Ensured that you cant wrench 2 identical pipes on one tile
Ensured you can't remotely unwrench pipes
Declaration
https://i.imgur.com/vm6bQ0i.png
https://i.imgur.com/cXirMb8.png
Changelog
🆑
add: Added an auto-wrenching toggle to the RPD UI
add: BRPD can wrench down from a distance
del: Removed wrench requirement for wrenching pipes down
fix: Transit tubes are now screwed instead of wrenched
/:cl: