Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPDs auto-wrenching #26775

Closed
wants to merge 0 commits into from
Closed

RPDs auto-wrenching #26775

wants to merge 0 commits into from

Conversation

Toastical
Copy link
Contributor

@Toastical Toastical commented Sep 14, 2024

What Does This PR Do

  • Removes the wrench requirement for automatic wrenching

  • Allows BRPD to wrench down remotely

  • Adds a UI toggle for the automatic wrenching behaviour

  • Fixes transit tubes using the wrong tool act

Why It's Good For The Game

Allows the BRPD to be consistent with the RPD (and less useless) and makes auto-wrenching clearer for newer players!

Allows the BRPD to be turned into a cyborg module in a future PR

Images of changes

2024-09-14.16-58-24.mp4

Testing

  • Ensured the RPDs dont behave like wrenches outside of wrenching pipes down

  • Ensured that you cant wrench 2 identical pipes on one tile

  • Ensured you can't remotely unwrench pipes


Declaration

Changelog

🆑
add: Added an auto-wrenching toggle to the RPD UI
add: BRPD can wrench down from a distance
del: Removed wrench requirement for wrenching pipes down
fix: Transit tubes are now screwed instead of wrenched
/:cl:

@ParadiseSS13-Bot
Copy link
Contributor

Your PR has been put on hold as your GitHub account is not linked to a Paradise forums account.

Please link your account at https://www.paradisestation.org/forum/custom/link_github_account.php

Headcoders may ignore this in specific circumstances (Minor fix PR, trusted contributor from another codebase, anything at their discretion)

@ParadiseSS13-Bot ParadiseSS13-Bot added the On Hold Its gonna be a while before this is reviewed label Sep 14, 2024
Copy link
Contributor

@Fordoxia Fordoxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DM code looks good to me.

TGUI is witchcraft so I cannot comment on the code there.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally TGUI This PR modifies TGUI, will conflict labels Sep 14, 2024
@Coolrune206
Copy link
Contributor

If the BRPD can wrench remotely, I think it will be necessary to prevent it from working through walls (unless such a check exists already). Consider clings, who can get x-ray and turn into a ventcrawling monkey freely using abilities available roundstart, able to make a pre-wrenched vent pipe into any room they want.

@1080pCat
Copy link
Contributor

If the BRPD can wrench remotely, I think it will be necessary to prevent it from working through walls (unless such a check exists already). Consider clings, who can get x-ray and turn into a ventcrawling monkey freely using abilities available roundstart, able to make a pre-wrenched vent pipe into any room they want.

from what i know this'd be.. a task.

unrelated to this, but im somewhat worried about people using the BRPD with the disposal bins to rapidly close up halls with wrenched bins

@Fordoxia
Copy link
Contributor

Fordoxia commented Sep 15, 2024

If the BRPD can wrench remotely, I think it will be necessary to prevent it from working through walls (unless such a check exists already). Consider clings, who can get x-ray and turn into a ventcrawling monkey freely using abilities available roundstart, able to make a pre-wrenched vent pipe into any room they want.

from what i know this'd be.. a task.

unrelated to this, but im somewhat worried about people using the BRPD with the disposal bins to rapidly close up halls with wrenched bins

This is also a concern with RPDs (which are currently able to auto-wrench with a wrench in hand). Even if no wrenching occurs (IIRC the unwrenched bins still have density. Also an issue with transit tube stations).

One solution would be to just give it a 3-5 second do_after. Disposal bins are not placed very often, so it'd not really get in the way of making disposals rides or the like, but it WOULD stop you from spamming bins, much in the same way that holoprojectors and similar can't be spammed.

Another potential solution (and one I prefer) is remove the density of unwrenched bins (if they have it, I forget), and make it so they cannot be wrenched unless there's a disposals trunk on the same tile. For transit stations, the screwdriver act already has a do_after, so ensuring it's not dense when secured would also be good.

@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Sep 16, 2024
@Toastical Toastical closed this Sep 16, 2024
@Toastical Toastical mentioned this pull request Sep 20, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Merge Conflict This PR is merge conflicted On Hold Its gonna be a while before this is reviewed TGUI This PR modifies TGUI, will conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants