Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thurible - Holy Incense Burner #26713

Merged
merged 18 commits into from
Oct 10, 2024
Merged

Conversation

PollardTheDragon
Copy link
Contributor

@PollardTheDragon PollardTheDragon commented Sep 7, 2024

What Does This PR Do

Adds the thurible item, which is a holy artifact used to burn incense and spread it while swung from a chain. The thurible will start in the chaplain's locker. There is only one thurible on the station.

Thurible's have a reagent capacity of 50. When ignited with a lighter, welder, or other fire source, they begin to spread their reagents to adjacent tiles and mobs as smoke, which can be inhaled if one is not wearing internals. Using 2 reagents per process cycle, it can be swung about 25 times from when it is filled. The flame can be extinguished in hand or when the reagents are empty. While burning, the thurible cannot be stored in a bag.

There is a limit to what reagents that can be inserted into the thurible, but exposing it to unholy water will corrupt it and make it able to take any reagent inserted. The allowed reagents are identical to the ones limited in hyposprays, but it also includes water, holy water, nicotine, happiness, lsd, thc, cbd, and space drugs, so that the user can instead use it to hotbox a room if they so choose.

Why It's Good For The Game

A lot of religious items are lacking on paradise, and giving service jobs thematic items that are useful for both RP and still have mechanics for use is a good thing. The thurible can be...

  • Used during rituals or processions by the chaplain as religious iconography
  • Used to harden places against revenants with holy water, instead of using blessed fire extinguishers
  • Used by thieving tiders to hotbox a room
  • Given to religious ERTs as another tool for inquisitor use
  • Used by chaplains who want to act as clerics by inserting consumed-healing reagents such as saline-glucose.

Images of changes

image
image
image
image

Testing

Spawned in, grabbed thurible from chaplain locker. Put saline and holy water in the thurible. Beat up some skells. Ignited thurible. Skrells slowly healed from saline smoke. Spawned a revenant. Revenant could not move over the blessed tiles from the holy water exposure. Tried to add sarin. Sarin was banished. Added unholy water, thurible was corrupted. Added sarin successfully. Poisoned myself with a lit thurible containing sarin.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

image


Changelog

🆑
add: Added thuribles
tweak: Put a thurible in the chaplain's locker
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Sep 7, 2024
@SynthTwo
Copy link
Contributor

SynthTwo commented Sep 7, 2024

!wiki_label

@github-actions github-actions bot added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Sep 7, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added Sprites This PR modifies the game sprites -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally labels Sep 8, 2024
@PollardTheDragon PollardTheDragon marked this pull request as ready for review September 13, 2024 07:24
@PollardTheDragon PollardTheDragon changed the title Thurible - Holy Incense Burner [WIP] Thurible - Holy Incense Burner Sep 13, 2024
code/game/objects/items/weapons/thurible.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/thurible.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/thurible.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/thurible.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/thurible.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/thurible.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/thurible.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/thurible.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/thurible.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/thurible.dm Outdated Show resolved Hide resolved
@Burzah Burzah requested a review from Christasmurf September 16, 2024 03:20
Copy link
Contributor

@Christasmurf Christasmurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sprites and related icon good looking good

Co-authored-by: Luc <[email protected]>
Signed-off-by: PollardTheDragon <[email protected]>
@ParadiseSS13-Bot ParadiseSS13-Bot removed the -Status: Awaiting review This PR is awaiting review from the review team label Oct 3, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting merge This PR is ready for merge label Oct 3, 2024
code/game/objects/items/weapons/thurible.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/thurible.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/thurible.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/thurible.dm Outdated Show resolved Hide resolved
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting merge This PR is ready for merge labels Oct 6, 2024
Copy link
Member

@DGamerL DGamerL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Oct 8, 2024
@S34NW S34NW added this pull request to the merge queue Oct 10, 2024
Merged via the queue into ParadiseSS13:master with commit 46887a3 Oct 10, 2024
12 checks passed
@BAGELMENSK
Copy link

HELL YEAH WOOOOOOOOO

@PollardTheDragon PollardTheDragon deleted the Thurible branch November 23, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Sprites This PR modifies the game sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants