-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Administration tool: Build mode offer tool to quickly offer large amount of mobs. #26712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadiseSS13-Bot
added
-Status: Awaiting type assignment
This PR is waiting for its type to be assigned internally
Sprites
This PR modifies the game sprites
labels
Sep 7, 2024
chuga-git
suggested changes
Sep 7, 2024
Co-authored-by: chuga-git <[email protected]> Signed-off-by: meow20 <[email protected]>
lewcc
added
Administration
This PR relates to ingame administration features
Feature
This PR is a new addition to the game
labels
Sep 8, 2024
lewcc
reviewed
Sep 10, 2024
ParadiseSS13-Bot
added
-Status: Awaiting approval
This PR is waiting for approval internally
and removed
-Status: Awaiting type assignment
This PR is waiting for its type to be assigned internally
labels
Sep 11, 2024
lewcc
reviewed
Sep 13, 2024
ParadiseSS13-Bot
added
-Status: Awaiting review
This PR is awaiting review from the review team
and removed
-Status: Awaiting approval
This PR is waiting for approval internally
labels
Sep 14, 2024
Co-authored-by: Luc <[email protected]> Signed-off-by: meow20 <[email protected]>
lewcc
approved these changes
Sep 17, 2024
ParadiseSS13-Bot
added
-Status: Awaiting merge
This PR is ready for merge
and removed
-Status: Awaiting review
This PR is awaiting review from the review team
labels
Sep 17, 2024
Burzah
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
-Status: Awaiting merge
This PR is ready for merge
Administration
This PR relates to ingame administration features
Feature
This PR is a new addition to the game
Sprites
This PR modifies the game sprites
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Adds a new build mode mode for admins to select hours required and whether to show their role.
Since its easy to click a mob twice or if a mouse doubleclicks, the PR prevents a mob from being offered while it's prompt to possess it is still visible to dchat.
I've read coding requirements and applied the guidelines there to the best of my ability as far as I can tell.
If I knew this pr will affect this many files and require this much code I wouldn't touch it -.- I have no clue what the changes in traits.dm and trait_helpers.dm do and how much they are needed or if they are up to standard so I hope someone takes a good look at them.
The code at line 172 to 176 is bit of a mess but it would require a genius or refactoring the whole proc to make it look more sane I assume.
"/datum/buildmode_mode/offer/handle_click" is mostly yoinked from all other buildmode modes, I have no physical clue what's happening there and why is taking input of a mob at a mouse click so complicated.Why It's Good For The Game
Only way to offer mobs (outside pre-made stuff like ERT, deathsquad ETC) is to sluggishly select each one of them in the VV dropdown menu, and you will still be asked about playtime requirement and whether to show role each time.
Testing
I offered a carbon mob and a simple mob with various configurations of the build mode + tested that offering from VV dropdown menu still works as intended.
Declaration