Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Administration tool: Build mode offer tool to quickly offer large amount of mobs. #26712

Merged
merged 9 commits into from
Sep 19, 2024

Conversation

meow20
Copy link
Contributor

@meow20 meow20 commented Sep 7, 2024

What Does This PR Do

Adds a new build mode mode for admins to select hours required and whether to show their role.

Since its easy to click a mob twice or if a mouse doubleclicks, the PR prevents a mob from being offered while it's prompt to possess it is still visible to dchat.

I've read coding requirements and applied the guidelines there to the best of my ability as far as I can tell.

If I knew this pr will affect this many files and require this much code I wouldn't touch it -.- I have no clue what the changes in traits.dm and trait_helpers.dm do and how much they are needed or if they are up to standard so I hope someone takes a good look at them.

The code at line 172 to 176 is bit of a mess but it would require a genius or refactoring the whole proc to make it look more sane I assume.

"/datum/buildmode_mode/offer/handle_click" is mostly yoinked from all other buildmode modes, I have no physical clue what's happening there and why is taking input of a mob at a mouse click so complicated.

Why It's Good For The Game

Only way to offer mobs (outside pre-made stuff like ERT, deathsquad ETC) is to sluggishly select each one of them in the VV dropdown menu, and you will still be asked about playtime requirement and whether to show role each time.

Testing

I offered a carbon mob and a simple mob with various configurations of the build mode + tested that offering from VV dropdown menu still works as intended.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Sprites This PR modifies the game sprites labels Sep 7, 2024
@lewcc lewcc added Administration This PR relates to ingame administration features Feature This PR is a new addition to the game labels Sep 8, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Sep 11, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Sep 14, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Sep 17, 2024
@Burzah Burzah added this pull request to the merge queue Sep 19, 2024
Merged via the queue into ParadiseSS13:master with commit a091516 Sep 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Administration This PR relates to ingame administration features Feature This PR is a new addition to the game Sprites This PR modifies the game sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants