Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Request Consoles "new messages" displaying wrong #26680

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

Arthri
Copy link
Contributor

@Arthri Arthri commented Sep 4, 2024

What Does This PR Do

  • Request consoles will now properly inform the user that there are new high priority messages
  • Request consoles will now properly return to "no new messages" when messages are read

Why It's Good For The Game

Being told that there are new messages when there aren't is gaslighting the user

Testing

  • Opened a new request console and checked that it displays "no new messages"
  • Sent a normal-priority message to another request console and ran to it to check that it properly displays "there are new messages"
  • Read the messages in the aforementioned request console and checked that it properly returned to "no new messages"
  • Sent a high priority message to another request console and ran to it to check that it properly displays "new priority messages"
  • Read the messages in the aforementioned console and checked that it properly returned to "no new messages"

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑 cdui
fix: Request Consoles no longer display "There are new messages" after messages have been read
fix: Request Consoles will now properly display "NEW PRIORITY MESSAGES" when priority messages arrive
/:cl:

Sorry, something went wrong.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally TGUI This PR modifies TGUI, will conflict labels Sep 4, 2024
@BiancaWilkson BiancaWilkson added the Fix This PR will fix an issue in the game label Sep 7, 2024
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Sep 8, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Sep 11, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Sep 13, 2024
@Burzah Burzah removed the Merge Conflict This PR is merge conflicted label Sep 16, 2024
@Burzah Burzah added this pull request to the merge queue Sep 16, 2024
Merged via the queue into ParadiseSS13:master with commit 07ded0c Sep 16, 2024
12 checks passed
@Arthri Arthri deleted the fix-request-console-new-messages branch September 17, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Fix This PR will fix an issue in the game TGUI This PR modifies TGUI, will conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants