Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mindflayers v0.9, Playable Edition! #26596

Merged
merged 497 commits into from
Oct 30, 2024
Merged

Conversation

BiancaWilkson
Copy link
Contributor

@BiancaWilkson BiancaWilkson commented Aug 25, 2024

What Does This PR Do

Revitalizes #22001, with a functional antagonist.
Adds Mindflayers, a new antagonist type designed to be given if an IPC would otherwise roll vampire or changeling. They function similar to vampires, in that their gameplay loop is about kidnapping crew to grow stronger. Instead of spending blood on spells however, mindflayers get swarms in the form of brain damage dealt. Swarms are spent to unlock and upgrade abilities.

They have a heavy focus on customization and upgrading yourself via the many passives mindflayers can buy.
https://docs.google.com/spreadsheets/d/1kBtqozUu1UAixtaczA2C70K8ETcjuqjqqKAquB4PqQI/edit?usp=sharing
This is a spreadsheet with all the information on all the mindflayer abilities/passives we've made. Currently there are two main paths, destroyer and intruder. Buying abilities from a specific category does not lock you out of buying abilities from other categories, however you can only purchase a single stage 4 ability.

A special thanks to ItsMarmite for making the intro stinger effect for us!

Mindflayers can be contained via an implant that suppresses the ability for them to cast most of their spells. It can be printed at RnD after they get 5s, or ordered from cargo in a crate. You can also test someone for being a mindflayer by checking their reaction to chemical, made by combining space lube, teslium, and aluminum. Mindflayers will begin to jitter and spark when it's in their system, but it'll heat up any IPC that drinks it a dangerous amount.

So why v0.9?
Well, as much as I love to pretend to be a full stack developer, the menus and icons are still very ugly. They're functional, but ugly. Additionally, there were originally plans for a third category. I haven't given up on that quite yet, so that's why flayer_mob.dm still exists, its groundwork for the next category of mindflayers. Ideally a v1.0 would look better, and have that thrid ability tree that players could take.

Why It's Good For The Game

I already mentioned most of the reasoning in the previously linked PR, but to recap:
IPCs don't need to engage with 2/3 of the main antagonist types on paradise. Both in not being able to roll them, and having an immunity to at least some of each antagonists' kits. I think this new antagonist type will work well to not disrupt the current flow of rounds, while fitting in nicely as its own unique thing.

Images of changes

Gimme a bit

Testing

Extensively tested each abillity as it was being developed, then went back after everything was done and made sure everything still worked how I wanted it to.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

image

Changelog

🆑 DGamerL, Burza, BiancaWilkson
add: Mindflayers, an antagonist type rollable by IPCs who would otherwise roll cling or vampire.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Sprites This PR modifies the game sprites Sound This PR modifies the game sound TGUI This PR modifies TGUI, will conflict labels Aug 25, 2024
@BiancaWilkson BiancaWilkson added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Aug 25, 2024
@Burzah Burzah added the Balance This PR will modify how effective something is or isnt label Aug 25, 2024
@DGamerL DGamerL requested a review from lewcc October 26, 2024 22:54
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Oct 27, 2024
Copy link
Contributor

@lewcc lewcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good. Just some small things, and some outstanding comments from my past reviews, and I think it'll be in pretty good shape code-wise.

@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Oct 29, 2024
@SteelSlayer SteelSlayer removed the Merge Conflict This PR is merge conflicted label Oct 30, 2024
@DGamerL DGamerL requested a review from lewcc October 30, 2024 12:11
Copy link
Member

@S34NW S34NW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cursory glance

code/__DEFINES/mindflayer_defines.dm Outdated Show resolved Hide resolved
code/game/gamemodes/changeling/traitor_chan.dm Outdated Show resolved Hide resolved
Copy link
Member

@S34NW S34NW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see it, say it, sort it

@S34NW S34NW dismissed stale reviews from lewcc and Contrabang October 30, 2024 18:33

STALE

@S34NW S34NW enabled auto-merge October 30, 2024 18:34
@S34NW S34NW added this pull request to the merge queue Oct 30, 2024
Merged via the queue into ParadiseSS13:master with commit 036b8e0 Oct 30, 2024
12 checks passed
AyIong added a commit to ss220club/Paradise-SS220 that referenced this pull request Nov 1, 2024
## Что этот PR делает
Мергес апстрим.

## Changelog

:cl: Paradise SS13
add: Добавлен новый КПБ антагонист - Mindflayer. Вампир/генокрад на
манер КПБ. Подробности
[тут](ParadiseSS13#26596).
fix: ИИ больше не видит через скрытые камеры и камеры на синди базе.
fix: Заказы в консоли карго больше не застревают, если заказчик ушел в
крио.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Balance This PR will modify how effective something is or isnt Feature This PR is a new addition to the game Requires Space Law Update This PR requires an update to Space Law. Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Sound This PR modifies the game sound Sprites This PR modifies the game sprites Testmerge Active This PR is currently testmerged on production Testmerge Requested This PR has a pending testmerge request TGUI This PR modifies TGUI, will conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.