Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing modsuit causing infinitely bloody hands #26553

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

HMBGERDO
Copy link
Contributor

@HMBGERDO HMBGERDO commented Aug 19, 2024

What Does This PR Do

Fixes #26368
Makes modsuit storage unable to be bloodied
Not the storage module, storage itself which contains items
Since modsuit itself is not designed as a storage, it has its own "ghost" storage that contains items. If you just hit someone, got your hands covered in blood, then put something in the modsuit, this storage will get bloody and you would not be able to clean it since that thing does not exist for the player

Why It's Good For The Game

Bugs bad!

Testing

Compiled, put bloody items in modsuit, took them out, made sure you can clean it all


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
fix: Modsuits no longer create infinite bloody hands
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Aug 19, 2024
@Burzah Burzah added the Fix This PR will fix an issue in the game label Aug 21, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Aug 24, 2024
@lewcc lewcc added this pull request to the merge queue Aug 24, 2024
Merged via the queue into ParadiseSS13:master with commit 50b8535 Aug 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Fix This PR will fix an issue in the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting blood-stains on your MOD control unit causes INFINITE blood-stained hands
4 participants