Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanotrasen Career Trainer - REVIVAL (PT1) #26512

Merged
merged 73 commits into from
Dec 30, 2024
Merged

Conversation

LetXxx
Copy link
Contributor

@LetXxx LetXxx commented Aug 17, 2024

What Does This PR Do

An idea that first originated from the Senior Enlisted Adviser (SEA) role that CM has. Considering the different style of gameplay loop we have on paradise it needed a few changes to fit in. The NCT role is meant to teach players ICly, being it in-game mechanics or SOP related stuff. During this first part, they'll be added under command, as dignitary, later, moved into a new department called "PROCEDURE" under the command of the NTR/Magi and would be on the same level as an IAA.

They are provided with a NCT Data Chip, which allows them to copy the access of their scanned Trainee's ID. This chip ONLY works for the registered NCT. When you scan a new ID, it removes all of the old access.

Final concept is available on discord, if any other questions arise.

Standard Operating Procedures [WIP]

  1. NT Career Trainers are to wear their company-provided uniform and jacket OR their issued beret/hat at all times while on duty. They are free to choose a beret that best matches their primary field of knowledge if they so desire. Additionally, Identifying equipment SHOULD not be distributed to crew members.

  2. NT Career Trainers are to be available to all Crewmembers, regardless of Department. You may not only assist a singular Department.

  3. NT Career Trainers are not to do a Trainee's work for them.

  4. NT Career Trainers are to use NCT Data Chips only to acquire the access necessary for providing training. They are not to use said access for other purposes.

  5. In the event of a lost or stolen NCT Data Chip, the NT Career Trainer is to report the incident to their local Nanotrasen Representative or Station Captain.

  6. NT Career Trainers are permitted to carry a flash for self-defense.

Why It's Good For The Game

I believe it's a positive role for our community, providing tools to assist new players in-game with someone they can trust. We all know that SS13 is pretty complicated to learn, having someone giving you some advice should be pretty good.

Images of changes

image
Boxstation
image
Deltastation
image
Metastation
image
image
Cerestation
image
EmeraldStation
image

Testing

Hopped in, joined as NCT, scanned a few IDs, checked if the blacklisted accesses were actually blacklisted, tested if I was able to scan an ERT ID, tested the autoresponse by mhelping and using it. Tested if I was able to make a guest passes using the data-chip (couldn't), tested if I could swipe for ERT (couldn't).


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

image
image


Changelog

🆑
add: New role "Nanotrasen Career Trainer" (NCT). A mentor locked role responsible for in-game teaching/advising.
add: New item "NCT Data-chip", allowing you to copy access similar to an agent ID. It's locked to the NCT only, has some access blacklisted.
add: New autoresponse for MHELPs. "NCT Dispatch", upon selection, it'll notify the in-game NCT with a headset message, telling the requester's in-game name/role.
imageadd: A few sprites were added for the new role! Rejoice! Thank you Christa!
add: An office has been added to all maps.
tweak: On metastation, the janitor's room has been moved closer to engineering. NCT office is now in their old place.
tweak: On deltastation, the explorer's room is now smaller.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Sprites This PR modifies the game sprites labels Aug 17, 2024
Co-authored-by: Aylong <[email protected]>
Signed-off-by: Pedro <[email protected]>
Copy link
Member

@DGamerL DGamerL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot the restricted jobs in:

  • vampire_gamemode.dm
  • trifecta.dm
  • revolution.dm

code/controllers/subsystem/tickets/SSmentor_tickets.dm Outdated Show resolved Hide resolved
code/controllers/subsystem/tickets/SSmentor_tickets.dm Outdated Show resolved Hide resolved
code/game/jobs/job/supervisor.dm Outdated Show resolved Hide resolved
code/game/machinery/guestpass.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/radio/headset.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/cards_ids.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/cards_ids.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/cards_ids.dm Show resolved Hide resolved
code/game/objects/items/weapons/cards_ids.dm Outdated Show resolved Hide resolved
code/modules/client/preference/character.dm Outdated Show resolved Hide resolved
@DGamerL DGamerL requested a review from Burzah August 17, 2024 14:02
Copy link
Member

@Burzah Burzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things to start.

code/controllers/subsystem/tickets/SSmentor_tickets.dm Outdated Show resolved Hide resolved
code/game/jobs/job/supervisor.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/cards_ids.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/cards_ids.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/cards_ids.dm Outdated Show resolved Hide resolved
@LetXxx LetXxx requested review from DGamerL and Burzah August 17, 2024 18:27
@SynthTwo
Copy link
Contributor

!wiki_label

@github-actions github-actions bot added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Aug 17, 2024
@github-actions github-actions bot added Merge Conflict This PR is merge conflicted and removed Merge Conflict This PR is merge conflicted labels Dec 1, 2024
Copy link
Member

@Burzah Burzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are going to have another mapping conflict that will need to be examined. Cerestation was just updated this morning and it affects the side of the map that the office is located in.

Copy link
Member

@DGamerL DGamerL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please do a merge master
Considering this PR is older than the attack refactor, you're not required to move over the attack chain stuff!

code/controllers/subsystem/tickets/SSmentor_tickets.dm Outdated Show resolved Hide resolved
code/datums/outfits/plasmamen_outfits.dm Show resolved Hide resolved
code/datums/outfits/plasmamen_outfits.dm Show resolved Hide resolved
code/game/objects/items/weapons/cards_ids.dm Outdated Show resolved Hide resolved
Copy link
Contributor

@warriorstar-orion warriorstar-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for mapping.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Dec 11, 2024
@github-actions github-actions bot added Merge Conflict This PR is merge conflicted and removed Merge Conflict This PR is merge conflicted labels Dec 11, 2024
Copy link
Member

@Burzah Burzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and I want to get moving forward with this PR.
I appreciate all the work you have done reviving this.
Look at Christa's review when able and settle the last merge conflict.
Thanks for sticking with it.

@github-actions github-actions bot added Merge Conflict This PR is merge conflicted and removed Merge Conflict This PR is merge conflicted labels Dec 30, 2024
code/modules/clothing/spacesuits/plasmamen.dm Outdated Show resolved Hide resolved
code/modules/clothing/head/job_hats.dm Outdated Show resolved Hide resolved
@DGamerL DGamerL added this pull request to the merge queue Dec 30, 2024
Merged via the queue into ParadiseSS13:master with commit b55bef2 Dec 30, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Feature This PR is a new addition to the game Map Edit This PR will modify a map Merge Conflict This PR is merge conflicted Requires SOP Update This PR requires an update to our Standard Operating Procedures (SOP). Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Sprites This PR modifies the game sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.