-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nanotrasen Career Trainer - REVIVAL (PT1) #26512
Conversation
Co-authored-by: Aylong <[email protected]> Signed-off-by: Pedro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot the restricted jobs in:
vampire_gamemode.dm
trifecta.dm
revolution.dm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things to start.
!wiki_label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are going to have another mapping conflict that will need to be examined. Cerestation was just updated this morning and it affects the side of the map that the office is located in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please do a merge master
Considering this PR is older than the attack refactor, you're not required to move over the attack chain stuff!
code/modules/antagonists/traitor/contractor/datums/objective_contract.dm
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for mapping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, and I want to get moving forward with this PR.
I appreciate all the work you have done reviving this.
Look at Christa's review when able and settle the last merge conflict.
Thanks for sticking with it.
b55bef2
What Does This PR Do
An idea that first originated from the Senior Enlisted Adviser (SEA) role that CM has. Considering the different style of gameplay loop we have on paradise it needed a few changes to fit in. The NCT role is meant to teach players ICly, being it in-game mechanics or SOP related stuff. During this first part, they'll be added under command, as dignitary, later, moved into a new department called "PROCEDURE" under the command of the NTR/Magi and would be on the same level as an IAA.
They are provided with a NCT Data Chip, which allows them to copy the access of their scanned Trainee's ID. This chip ONLY works for the registered NCT. When you scan a new ID, it removes all of the old access.
Final concept is available on discord, if any other questions arise.
Standard Operating Procedures [WIP]
NT Career Trainers are to wear their company-provided uniform and jacket OR their issued beret/hat at all times while on duty. They are free to choose a beret that best matches their primary field of knowledge if they so desire. Additionally, Identifying equipment SHOULD not be distributed to crew members.
NT Career Trainers are to be available to all Crewmembers, regardless of Department. You may not only assist a singular Department.
NT Career Trainers are not to do a Trainee's work for them.
NT Career Trainers are to use NCT Data Chips only to acquire the access necessary for providing training. They are not to use said access for other purposes.
In the event of a lost or stolen NCT Data Chip, the NT Career Trainer is to report the incident to their local Nanotrasen Representative or Station Captain.
NT Career Trainers are permitted to carry a flash for self-defense.
Why It's Good For The Game
I believe it's a positive role for our community, providing tools to assist new players in-game with someone they can trust. We all know that SS13 is pretty complicated to learn, having someone giving you some advice should be pretty good.
Images of changes
Boxstation
Deltastation
Metastation
Cerestation
EmeraldStation
Testing
Hopped in, joined as NCT, scanned a few IDs, checked if the blacklisted accesses were actually blacklisted, tested if I was able to scan an ERT ID, tested the autoresponse by mhelping and using it. Tested if I was able to make a guest passes using the data-chip (couldn't), tested if I could swipe for ERT (couldn't).
Declaration
Changelog
🆑
add: New role "Nanotrasen Career Trainer" (NCT). A mentor locked role responsible for in-game teaching/advising.
add: New item "NCT Data-chip", allowing you to copy access similar to an agent ID. It's locked to the NCT only, has some access blacklisted.
add: New autoresponse for MHELPs. "NCT Dispatch", upon selection, it'll notify the in-game NCT with a headset message, telling the requester's in-game name/role.
imageadd: A few sprites were added for the new role! Rejoice! Thank you Christa!
add: An office has been added to all maps.
tweak: On metastation, the janitor's room has been moved closer to engineering. NCT office is now in their old place.
tweak: On deltastation, the explorer's room is now smaller.
/:cl: