Fixes tether module being able to tether yourself #26403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadiseSS13-Bot
added
the
-Status: Awaiting type assignment
1080pCat
reviewed
Aug 6, 2024
Spaghetti-bit
approved these changes
Aug 6, 2024
Co-authored-by: 1080pCat <[email protected]> Signed-off-by: Burzah <[email protected]>
Spaghetti-bit
suggested changes
Aug 6, 2024
Should be good now, if you want to take a look again. |
lewcc
approved these changes
Aug 6, 2024
Burzah
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Fixes #23414 by checking if the target and source are on the same turf.
Why It's Good For The Game
I promise no one is trying to grapple their own modsuit that they're already wearing.
Testing
Made sure trying to tether myself or any of my items didn't work, made sure failing to tether myself didn't put the module on cooldown.
Changelog
🆑
fix: Modsuit tether module can no longer tether to anything already on your tile
/:cl: