-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anti-Assistant Food Carts (E.A.T.) #26021
Anti-Assistant Food Carts (E.A.T.) #26021
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just like New York Hotdog Foodcart, this is based. Good work. Code looks good.
10/10 would commission the people who made the nuke anchors to make food carts again.
Co-authored-by: Ryan <[email protected]> Signed-off-by: SchrodingersWolf <[email protected]>
Co-authored-by: Luc <[email protected]> Signed-off-by: SchrodingersWolf <[email protected]>
Co-authored-by: Ryan <[email protected]> Signed-off-by: SchrodingersWolf <[email protected]>
…/Paradise into stop-chef-theft
This PR has been marked as stale due to lack of activity, please continue working on the PR and/or address any comments within 7 days or we will have to close it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One nit, but that's it.
Co-authored-by: Burzah <[email protected]> Signed-off-by: SchrodingersWolf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes just for the access thing. LGTM otherwise
|
||
/obj/machinery/smartfridge/secure/foodcart/Initialize(mapload) | ||
. = ..() | ||
req_one_access_txt = "[ACCESS_KITCHEN], [ACCESS_BAR]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check that this works? req_one_access_txt
seems to only split ;
, and the accesses might have to have no spaces between
This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord. |
This pull request has not received any updates since being marked stale, and as such is now being automatically closed. Please feel free to re-open this pull request or open a new one once you have new updates. |
What Does This PR Do
Introducing the brand new Entrée Armoured Transport (E.A.T.), an exciting new refresh of the existing Food and Drinks Cart!
Just like its predecessor, the EAT will allows you to store fresh food and cold drinks within its compartments, but now perfectly secured against unauthorised access. The dark days of ungrateful crew stealing from you when you are slaughtering Pun Pun in the backrooms are long gone!
Rioting Assistants breaking in to space your Food Cart so nobody gets to eat? Not to worry, for you can simply tap your ID on the EAT and activate the plasteel anchors! Our unique bolting technologies will make sure that all of your meticiously crafted cuisine will still look JUST like how you left it before you heroically fought off the Greytide with your insane martial art moves (Any resemblence to Nanotrasen's Nuclear Fission Devices are purely coincidental).
In the unlikely situation where your EAT does break down, simply procure any airlock electronics - Our patented Donk Hotswap Technologies allow seamless removal of any broken electronics, no screwdrivers or crowbars required!
Why It's Good For The Game
Crew loves to riot and break inside the Kitchen to steal food from the Chef whenever they want to charge for their services. They do get CQC to protect themselves from trespassers, but the Chef is still only one man against the entire station... A secure Smartfridge would allow for Chefs to charge for food much more easily according to their SoPs.
Testing
Spawned in to all four stations, verified food cart is the secure type.
Tried taking food from the food cart with Chef ID, agent ID with Chef access, and Captain ID, as well as trying to bolt the cart, works.
Tried taking food from the food cart with Assistant ID, as well as unbolting the cart, doesn't work
Tried emagging food cart, it unbolted and I could steal food from it.
Tried using an airlocks electronic on emagged food cart, food cart repaired.
Changelog
🆑
tweak: Chef's Food Cart now has a slew of security features to prevent theft
/:cl: