-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merges the Hug Module With the Cyborg Gripper #26007
Conversation
Co-authored-by: Sheep <[email protected]> Signed-off-by: CRUNCH <[email protected]>
|
I honestly don't see this being a big deal at all, but I have removed the functionality from all the borgs that don't already have it. |
Throws in some missing apostrophes, capitalisation, and the letter "s."
Increases the amount of cash in the Syndicate Briefcase Full of Cash from 600 Cr to 1000 Cr
This PR has unfortunately failed to pass the relevant team vote, with 0 for and 5 against.
Please feel free to discuss this with the relevant team and see if you can rework it into something acceptable to them. |
This PR didn't give any borgs the ability to help up that did not already possess it. One of these reasons doesn't even have anything to do with the PR. |
Co-authored-by: Burzah <[email protected]> Signed-off-by: CRUNCH <[email protected]>
Co-authored-by: Burzah <[email protected]> Signed-off-by: CRUNCH <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tentative approval. I would like another reviewer to check out the attack chain logic.
Co-authored-by: Burzah <[email protected]> Signed-off-by: CRUNCH <[email protected]>
Signed-off-by: CRUNCH <[email protected]>
What Does This PR Do
Removes the cyborg gripper from the medical module.
Functions have been transferred to the cyborg gripper, allowing any borg with a gripper to give hugs and boops!
It has been adjusted in the following ways:
attack_self()
(as the gripper already hasattack_self()
interactions). Help for regular hugs, harm for awkward/emagged hugs. Targeting the head to apply normal/awkward baps instead of hugging remains unchanged.Why It's Good For The Game
This removes an item from the mediborg's inventory. Streamlining it is good due to the large amount of items that have to be kept track of.
All gripper-equipped borgs can now display appreciation/malice with the application of hugs and baps.
The damage output of the hug module's emagged mode shouldn't have too much effect on balance, as emagged borgs already have access to quite powerful equipment and/or items that do the same or more damage.
Testing
Hugged a skrell.
Playfully bapped a skrell.
Hugged a skrell, but in an awkward way.
Bapped a skrell.
Crushed a skrell.
Punched a skrell in the face.
Applied many headpats to Ian.
Hugged myself.
Hugged myself harder.
Punched myself.
Changelog
🆑
del: Removed the Hug Module from the medical borg.
tweak: Tweaked all grippers to have modified Hug Module functionality.
/:cl: