Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CraftMetaItem#addAttributeModifier duplication check #9995

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Fix CraftMetaItem#addAttributeModifier duplication check #9995

merged 1 commit into from
Dec 3, 2023

Conversation

hyper1423
Copy link
Contributor

Fixes #9993

@hyper1423 hyper1423 requested a review from a team as a code owner December 2, 2023 23:27
Machine-Maker
Machine-Maker approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@Machine-Maker Machine-Maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue. Tested with the linked issue's reproduction steps

@lynxplay lynxplay merged commit 40872ec into PaperMC:master Dec 3, 2023
2 checks passed
lynxplay pushed a commit to lynxplay/paper that referenced this pull request Feb 23, 2024
@hyper1423 @lynxplay
Fix CraftMetaItem#addAttributeModifier duplication check (PaperMC#9995)
9d3fe90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Machine-Maker Machine-Maker Machine-Maker approved these changes

@lynxplay lynxplay lynxplay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ItemMeta#addAttributeModifier wrongly throws IllegalArgumentException
3 participants
@hyper1423 @Machine-Maker @lynxplay