-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xp orb spawn reason for frogs #8045
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this patch should mark the ExperienceOrb ctor that doesn't take a SpawnReason as deprecated. Just to increase the likelihood
that usages of it are caught earlier.
I can deprecate the default constructor if you wants ? Also there is a decompile issue in the getBrain method return which needs to be cast into a Brain<Frog> before merging this one and the new event |
Yeah, add the |
Track the spawn reason of the xp orb dropped when frogs breeds