Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xp orb spawn reason for frogs #8045

Merged
merged 6 commits into from
Jul 7, 2022

Conversation

Lulu13022002
Copy link
Contributor

Track the spawn reason of the xp orb dropped when frogs breeds

Copy link
Member

@Machine-Maker Machine-Maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this patch should mark the ExperienceOrb ctor that doesn't take a SpawnReason as deprecated. Just to increase the likelihood
that usages of it are caught earlier.

@Lulu13022002
Copy link
Contributor Author

Lulu13022002 commented Jun 25, 2022

I can deprecate the default constructor if you wants ? Also there is a decompile issue in the getBrain method return which needs to be cast into a Brain<Frog> before merging this one and the new event

@Machine-Maker
Copy link
Member

Yeah, add the @Deprecated to that constructor.

@Lulu13022002 Lulu13022002 requested a review from a team as a code owner July 4, 2022 20:12
@electronicboy electronicboy merged commit c4782f5 into PaperMC:master Jul 7, 2022
@Lulu13022002 Lulu13022002 deleted the feat/xpfrog branch July 8, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants