Increase outdated build delay to two weeks #12063
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electronicboy
approved these changes
Feb 3, 2025
NoahvdAa
approved these changes
Feb 3, 2025
|
nice moment for in future improvement this? or just remove? |
|
In the future we can maybe just switch this towards actually querying the API to print if an update is available post server init, but, that's low priority |
Ifiht
added a commit
to Ifiht/Aincrad
that referenced
this pull request
Feb 8, 2025
[ci skip] Increase outdated build delay to two weeks (PaperMC#12063)
Ifiht
pushed a commit
to Ifiht/Aincrad
that referenced
this pull request
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our old upstream loved to always randomly shift this value to arbitrary amounts of days, but since going stable this hasn't been touched yet. Two weeks seems like a good middle ground to keep it at (though I wonder if this message is even still needed).
The "as per instructions" part also seems like a holdout from spigot, since our downloads page has no instructions.