Fix TargetHitEvent#getSignalStrength() post-hard-fork #11897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynxplay
added
the
build-pr-jar
Machine-Maker
requested changes
Jan 4, 2025
kennytv
added
type: bug
lynxplay
approved these changes
Jan 4, 2025
Machine-Maker
approved these changes
Jan 4, 2025
Machine-Maker
added
for: future
|
It's not so much "typos" as it's just hunks that applied successfully but the names of local variables changed which changed some functionality. The diff between this and pre-hard fork is way too littered with all the other renaming/decompiler changes. Our tooling also changes the local variable names to much nicer names (in some cases) which renames all the other local variables as well. So it's just a matter of identifying those cases. We did several pass throughs of the whole diff right after, and found a bunch. |
lynxplay
pushed a commit
to notTamion/paper
that referenced
this pull request
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in discord
TargetHitEvent#getSignalStrength()return just 20 or 8 based in the projectile this behaviour is a side-effect caused by hard-fork where pre-hard-fork the value used is called "i" (ref: https://github.com/PaperMC/Paper/blob/master/patches/server/0441-Add-TargetHitEvent.patch and broken in e9680a5#diff-3a492050417244fc5b90189b40134f0124f010ffb92b94158329562b71014f59R16) but now is calledredstoneStrengthandiis just used for another thing.Download the paperclip jar for this pull request: paper-11897.zip