Improve performance of PoiCompetitorScan by unrolling stream #11871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warriorrrr
reviewed
Dec 31, 2024
...r-server/patches/sources/net/minecraft/world/entity/ai/behavior/PoiCompetitorScan.java.patch
Outdated
Show resolved
Hide resolved
|
The profiling results look very impressive. You may have forgotten to return the winner to ifPresent? .reduce |
The result wasn't used at all before so there is no need to return anything because the only thing it does is the sideffect. |
...r-server/patches/sources/net/minecraft/world/entity/ai/behavior/PoiCompetitorScan.java.patch
Outdated
Show resolved
Hide resolved
NoahvdAa
approved these changes
Jan 3, 2025
lynxplay
force-pushed
the
poicompetitorscan-improvements
branch
from
745c836 to
fe1642a
Compare
lynxplay
approved these changes
Jan 3, 2025
Machine-Maker
approved these changes
Jan 4, 2025
lynxplay
pushed a commit
to notTamion/paper
that referenced
this pull request
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was debugging villagers and I noticed that the reduce on the stream has massive overhead so I decided to unroll it.
Here are sparks for before and after:
Before
After
Those numbers are with 229 active villagers on R7 5700X with 64GB of RAM.
Here is the test world:
world.tar.gz