Disable memory reserve allocating #10180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is 100% intentional, this memory will pretty much end up in old gen and not be a real factor towards anything until you hit "oh shit", at which point, it's freed in order to pray that they can close the JVM in a safe and effective™ manner |
|
Then again, the place its used is dumb, I'm not 100% sure on removing this, it's pretty much a pointless slab of memory in which is effectively useless, so it's not a big deal in any manner, not sure, either we remove it or we figure out a manner of effectively using it if needs be |
Owen1212055
approved these changes
Jan 20, 2024
lynxplay
approved these changes
Jan 27, 2024
lynxplay
force-pushed
the
feat/disable-memory-reserve
branch
from
6e2aed7 to
a215ca1
Compare
lynxplay
approved these changes
Jan 27, 2024
Machine-Maker
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, the memory that this method reserves is only ever released by the server in one spot, which is unused in paper. By not allocating it we save about 10,5 MB of memory that can then be used elsewhere