[ci skip] Fix incorrect documentation for BlockDropItemEvent #10175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generally we don’t even add paper comments for Javadoc changes. Also, this change can be merged in with an existing patch called something like “fix javadocs” or “fix upstream javadocs”. |
|
Thank you, I'll do that in the morning |
lynxplay
force-pushed
the
fix/incorrect-documentation-blockdropitemevent
branch
from
98d90d4 to
629edf7
Compare
Machine-Maker
approved these changes
Jan 27, 2024
Machine-Maker
changed the title
lynxplay
approved these changes
Jan 27, 2024
lynxplay
added a commit
to lynxplay/paper
that referenced
this pull request
Feb 23, 2024
…#10175) Co-authored-by: Bjarne Koll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the incorrect Javadoc comment of the BlockDropItemEvent as described in #10133
I'm not entirely sure if the
// Paper end - Fix incorrect documentationis in the right place as it's between the Javadoc comment and the class definition.