-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add back optimise non-flush packet sending patch #10172
add back optimise non-flush packet sending patch #10172
Conversation
178960d
to
fea1f08
Compare
Has this been tested? I can't connect to the server. |
it's a small change in which packets which need to get out fast are generally marked as such, and this is working fine here, however, I do test behind a bungee proxy |
fea1f08
to
d29296a
Compare
Oops. Yes this has been tested and indeed was working, later I was testing out @electronicboy 's suggestion (which causes the player cannot connect to the server) and accidentally pushed that code change as I was out of focus for a bit. The change has been reverted, now this PR should work fine just like at the beginning and I have to be careful next time. Thank you for hitting me up! |
This patch broke the plugin that reads and modifies chat packets with ProtocolLib. |
Are there any log about this? |
This is basically down to how they hook the event loop stuff |
It seems like I have to open a PR on ProtocolLib to make their event loop hook extending |
Close this until I came up with a suitable solution. |
There are reasons I can think of why the original patch was dropped:
AbstractEventExecutor.LazyRunnable
had been deprecated since the release of Netty 4.1.92 (see Deprecates LazyRunnable netty/netty#13335)Although there is an alternative mechanism provided from the API reference of
AbstractEventExecutor
, the solution in this PR only requires a small amount of code changes.